Page MenuHomeElementl

refactor: convert toys to graph + job + op(eration)s
Needs ReviewPublic

Authored by rexledesma on Jun 23 2021, 8:27 PM.

Details

Test Plan

local

Diff Detail

Repository
R1 dagster
Branch
rl/toys-conversion (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2021, 8:51 PM
Harbormaster failed remote builds in B32540: Diff 40089!
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2021, 9:19 PM
Harbormaster failed remote builds in B32545: Diff 40096!
rexledesma retitled this revision from refactor(1/n): convert toys to graph + job + op(eration)s to refactor: convert toys to graph + job + op(eration)s.Jun 23 2021, 10:07 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2021, 10:28 PM
Harbormaster failed remote builds in B32551: Diff 40103!
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 24 2021, 12:04 AM
Harbormaster failed remote builds in B32559: Diff 40112!
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 24 2021, 1:36 AM
Harbormaster failed remote builds in B32567: Diff 40123!
python_modules/dagster-test/dagster_test/toys/branches.py
6–13

nit:
mypy
switch to tuple output typing

python_modules/dagster-test/dagster_test/toys/error_monster.py
122–123

nit: mypy ignore instead? since this is meant to trigger an error

135–136

^

python_modules/dagster-test/dagster_test/toys/repo.py
28–42

request: comments on the ones you couldn't convert with why

Thanks for putting this together Rex. This looks great. We should hold off on merging it until we've unexperimentalized the CRAG APIs, because we don't want users looking for example pipelines to deal with thrash.

python_modules/dagster-test/dagster_test/toys/composition.py
26

Any particular reason to keep around the input/output definitions here, but not on the graph definition above?