Page MenuHomeElementl
Differential D8501

refactor: convert toys to graph + job + op(eration)s
Needs ReviewPublic
Actions

Authored by • rexledesma on Jun 23 2021, 8:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 17, 6:41 AM
Unknown Object (File)
Mon, May 15, 5:12 PM
Unknown Object (File)
Sun, May 14, 7:01 AM
Unknown Object (File)
Sat, May 13, 11:28 AM
Unknown Object (File)
Wed, May 10, 4:41 AM
Unknown Object (File)
Tue, May 9, 5:48 PM
Unknown Object (File)
Tue, May 9, 3:58 AM
Unknown Object (File)
May 1 2023, 3:42 PM
View All Files
Subscribers
None

Details

Reviewers
• yuhan
• cdecarolis
• sandyryza
alangenfeld
Test Plan

local

Diff Detail

Repository
R1 dagster
Branch
rl/toys-conversion (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• rexledesma created this revision.Jun 23 2021, 8:27 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2021, 8:51 PM
Harbormaster failed remote builds in B32540: Diff 40089!
• rexledesma updated this revision to Diff 40096.Jun 23 2021, 8:55 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2021, 9:19 PM
Harbormaster failed remote builds in B32545: Diff 40096!
• rexledesma updated this revision to Diff 40103.Jun 23 2021, 10:06 PM

up

• rexledesma retitled this revision from refactor(1/n): convert toys to graph + job + op(eration)s to refactor: convert toys to graph + job + op(eration)s.Jun 23 2021, 10:07 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2021, 10:28 PM
Harbormaster failed remote builds in B32551: Diff 40103!
• rexledesma updated this revision to Diff 40111.Jun 23 2021, 11:37 PM

fix tests

• rexledesma updated this revision to Diff 40112.Jun 23 2021, 11:41 PM

up

Harbormaster failed remote builds in B32558: Diff 40111!Jun 24 2021, 12:01 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 24 2021, 12:04 AM
Harbormaster failed remote builds in B32559: Diff 40112!
• rexledesma updated this revision to Diff 40123.Jun 24 2021, 1:14 AM

up

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 24 2021, 1:36 AM
Harbormaster failed remote builds in B32567: Diff 40123!
• yuhan added a child revision: D8509: [crag food] convert schedules and sensors in toys.Jun 24 2021, 4:51 AM
• rexledesma updated this revision to Diff 40310.Jun 28 2021, 2:10 PM

up

Harbormaster completed remote builds in B32727: Diff 40310.Jun 28 2021, 2:33 PM
• rexledesma requested review of this revision.Jun 28 2021, 2:33 PM
alangenfeld added inline comments.Jun 30 2021, 5:54 PM
python_modules/dagster-test/dagster_test/toys/branches.py
6–13

nit:
mypy
switch to tuple output typing

python_modules/dagster-test/dagster_test/toys/error_monster.py
122–123

nit: mypy ignore instead? since this is meant to trigger an error

135–136

^

python_modules/dagster-test/dagster_test/toys/repo.py
28–42

request: comments on the ones you couldn't convert with why

• sandyryza added a comment.Jul 1 2021, 4:01 PM

Thanks for putting this together Rex. This looks great. We should hold off on merging it until we've unexperimentalized the CRAG APIs, because we don't want users looking for example pipelines to deal with thrash.

python_modules/dagster-test/dagster_test/toys/composition.py
26

Any particular reason to keep around the input/output definitions here, but not on the graph definition above?

alangenfeld resigned from this revision.Jul 2 2021, 9:36 PM
• sandyryza resigned from this revision.Jul 20 2021, 3:24 PM

Revision Contents
Changeset List

PathSize
python_modules/
dagster-test/
dagster_test/
toys/
53 lines
52 lines
80 lines
17 lines
11 lines
13 lines
81 lines
43 lines
72 lines
49 lines
34 lines
43 lines
20 lines
6 lines
38 lines
19 lines
dagster_test_tests/
94 lines
libraries/
dagster-airflow/
dagster_airflow_tests/
10 lines
6 lines

Diff 40310

View Options

python_modules/dagster-test/dagster_test/toys/branches.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/composition.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/error_monster.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/log_asset.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/log_file.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/log_s3.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/log_spew.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/longitudinal.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/many_events.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/repo.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/resources.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/retries.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/schedules.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/sensors.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/sleepy.py

Loading...
View Options

python_modules/dagster-test/dagster_test/toys/unreliable.py

Loading...
View Options

python_modules/dagster-test/dagster_test_tests/test_toys.py

Loading...
View Options

python_modules/libraries/dagster-airflow/dagster_airflow_tests/test_build_dags.py

Loading...
View Options

python_modules/libraries/dagster-airflow/dagster_airflow_tests/test_compile.py

Loading...