Page MenuHomePhabricator

Refactor PipelineRun
ClosedPublic

Authored by max on Tue, Aug 20, 11:14 PM.

Details

Reviewers
alangenfeld
schrockn
Group Reviewers
Restricted Project
Commits
R1:f31f3d525e46: Refactor PipelineRun
Summary

Stacked on D841 (I hope) -- simplifies the injection between RunStorage and PipelineRun.
Incidentally exposes very clearly the conflation of run and log storage in our system, and I think
the follow-on will easily pull them apart.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Tue, Aug 20, 11:14 PM
max edited the summary of this revision. (Show Details)Tue, Aug 20, 11:15 PM
max updated this revision to Diff 3878.Tue, Aug 20, 11:48 PM

Black

max updated this revision to Diff 3880.Wed, Aug 21, 12:13 AM

Rebase

alangenfeld accepted this revision.Wed, Aug 21, 2:51 PM

winclap

the only thing to consider is moving some stuff out to separate files

This revision is now accepted and ready to land.Wed, Aug 21, 2:51 PM
max updated this revision to Diff 3887.Wed, Aug 21, 3:19 PM

Rebase

This revision was automatically updated to reflect the committed changes.