Page MenuHomeElementl

[dagit] Add an id field to Mode
ClosedPublic

Authored by dish on Jun 23 2021, 6:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 7, 7:22 PM
Unknown Object (File)
Wed, Jan 18, 11:41 AM
Unknown Object (File)
Jan 1 2023, 5:20 PM
Unknown Object (File)
Dec 29 2022, 10:23 AM
Unknown Object (File)
Dec 24 2022, 10:26 PM
Unknown Object (File)
Dec 19 2022, 7:29 AM
Unknown Object (File)
Dec 14 2022, 1:51 AM
Unknown Object (File)
Dec 10 2022, 12:22 PM
Subscribers
None

Details

Summary

Now that we are querying mode more aggressively on Pipeline, we are ending up with more cases where the cached object in Apollo appears to be treated as a mismatch, and extra queries are performed. It appears to be because Mode does not have an ID, e.g. Apollo does not match the objects based on the name field alone.

Ideally this change will result in fewer network queries of the root repository query and search bootstrap query during simple navigation of Dagit.

Test Plan

View a pipeline in Dagit, click "Playground". Verify that the RootRepositoriesQuery and SearchBootstrapQuery are not requested. (In master, they currently are.)

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable