Paths

Table of Contentst

Differential D8495

[dagit] Add an id field to Mode
ClosedPublic
Actions

Authored by • dish on Jun 23 2021, 6:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 7, 7:22 PM

	Unknown Object (File)
	Wed, Jan 18, 11:41 AM

	Unknown Object (File)
	Jan 1 2023, 5:20 PM

	Unknown Object (File)
	Dec 29 2022, 10:23 AM

	Unknown Object (File)
	Dec 24 2022, 10:26 PM

	Unknown Object (File)
	Dec 19 2022, 7:29 AM

	Unknown Object (File)
	Dec 14 2022, 1:51 AM

	Unknown Object (File)
	Dec 10 2022, 12:22 PM

View All 37 Files

Subscribers

None

Details

Reviewers

• bengotow
• sandyryza
• prha
• dgibson

Commits

R1:4bbdc40cf037: [dagit] Add an id field to Mode

Summary

Now that we are querying mode more aggressively on Pipeline, we are ending up with more cases where the cached object in Apollo appears to be treated as a mismatch, and extra queries are performed. It appears to be because Mode does not have an ID, e.g. Apollo does not match the objects based on the name field alone.

Ideally this change will result in fewer network queries of the root repository query and search bootstrap query during simple navigation of Dagit.

Test Plan

View a pipeline in Dagit, click "Playground". Verify that the RootRepositoriesQuery and SearchBootstrapQuery are not requested. (In master, they currently are.)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• dish created this revision.Jun 23 2021, 6:20 PM

Harbormaster completed remote builds in B32529: Diff 40073.Jun 23 2021, 6:46 PM

• dish requested review of this revision.Jun 23 2021, 6:46 PM

• dish added a reviewer: • prha.Jun 24 2021, 3:37 PM

• prha accepted this revision.Jun 24 2021, 3:58 PM

This revision is now accepted and ready to land.Jun 24 2021, 3:58 PM

• dgibson accepted this revision.Jun 24 2021, 4:48 PM

Closed by commit R1:4bbdc40cf037: [dagit] Add an id field to Mode (authored by • dish). · Explain WhyJun 24 2021, 5:43 PM

This revision was automatically updated to reflect the committed changes.

• dish added a commit: R1:4bbdc40cf037: [dagit] Add an id field to Mode.

For more on this: https://www.apollographql.com/docs/react/caching/cache-field-behavior/#merging-non-normalized-objects

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

packages/

core/

src/

execute/

PipelineExecutionRoot.tsx

1 line

types/

ExecutionSessionContainerPipelineFragment.ts

PipelineExecutionRootQuery.ts

graphql/

1 line

nav/

FlatContentList.tsx

1 line

types/

pipelines/

PipelineTable.tsx

1 line

SidebarPipelineInfo.tsx

1 line

types/

PipelineExplorerFragment.ts

PipelineExplorerRootQuery.ts

PipelineTableFragment.ts

SidebarPipelineInfoFragment.ts

SidebarTabbedContainerPipelineFragment.ts

search/

types/

SearchBootstrapQuery.ts

useRepoSearch.tsx

1 line

workspace/

WorkspaceContext.tsx

1 line

types/

RepositoryPipelinesListQuery.ts

RootRepositoriesQuery.ts

python_modules/

dagster-graphql/

dagster_graphql/

schema/

pipelines/

9 lines

6 lines

Diff 40141

js_modules/dagit/packages/core/src/execute/PipelineExecutionRoot.tsx

Loading...

js_modules/dagit/packages/core/src/execute/types/ExecutionSessionContainerPipelineFragment.ts

Loading...

js_modules/dagit/packages/core/src/execute/types/PipelineExecutionRootQuery.ts

Loading...

js_modules/dagit/packages/core/src/graphql/schema.graphql

Loading...

js_modules/dagit/packages/core/src/nav/FlatContentList.tsx

Loading...

js_modules/dagit/packages/core/src/nav/types/NavQuery.ts

Loading...

js_modules/dagit/packages/core/src/pipelines/PipelineTable.tsx

Loading...

js_modules/dagit/packages/core/src/pipelines/SidebarPipelineInfo.tsx

Loading...

js_modules/dagit/packages/core/src/pipelines/types/PipelineExplorerFragment.ts

Loading...

js_modules/dagit/packages/core/src/pipelines/types/PipelineExplorerRootQuery.ts

Loading...

js_modules/dagit/packages/core/src/pipelines/types/PipelineTableFragment.ts

Loading...

js_modules/dagit/packages/core/src/pipelines/types/SidebarPipelineInfoFragment.ts

Loading...

js_modules/dagit/packages/core/src/pipelines/types/SidebarTabbedContainerPipelineFragment.ts

Loading...

js_modules/dagit/packages/core/src/search/types/SearchBootstrapQuery.ts

Loading...

js_modules/dagit/packages/core/src/search/useRepoSearch.tsx

Loading...

js_modules/dagit/packages/core/src/workspace/WorkspaceContext.tsx

Loading...

js_modules/dagit/packages/core/src/workspace/types/RepositoryPipelinesListQuery.ts

Loading...

js_modules/dagit/packages/core/src/workspace/types/RootRepositoriesQuery.ts

Loading...

python_modules/dagster-graphql/dagster_graphql/schema/pipelines/mode.py

Loading...

python_modules/dagster-graphql/dagster_graphql/schema/pipelines/pipeline.py

Loading...