Differential D8491

Cross-reference ECS reference deployment
ClosedPublic
Actions

Authored by • jordansanders on Jun 23 2021, 2:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 19, 1:04 AM

	Unknown Object (File)
	Thu, May 18, 7:50 PM

	Unknown Object (File)
	Thu, May 11, 10:22 AM

	Unknown Object (File)
	Wed, May 10, 1:00 PM

	Unknown Object (File)
	Apr 11 2023, 5:43 PM

	Unknown Object (File)
	Apr 7 2023, 10:32 AM

	Unknown Object (File)
	Apr 4 2023, 9:09 AM

	Unknown Object (File)
	Mar 31 2023, 10:46 AM

View All 86 Files

Subscribers

Details

Reviewers

• catherinewu
• dgibson
• johann

Commits

R1:9122845e8e81: Cross-reference ECS reference deployment

Summary

This links back out to GitHub to show the full ECS reference deployment.
Alternatively, we could create a new deployment guide in our docs site
with the contents of the README.

I think the rest of the AWS content is otherwise worth keeping (the RDS
and S3 stuff) so I didn't want to replace it wholesale.

Test Plan

none

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jordansanders created this revision.Jun 23 2021, 2:45 PM

• jordansanders added inline comments.Jun 23 2021, 2:47 PM

docs/content/deployment/guides/aws.mdx
16	Do we have strongly held opinions on where the technical directions for running the example should live (docs site, README, or both)? I tend to prefer it in the README and find some of our other back-references from READMEs to the docs site to be disruptive - but I'm happy to bias toward whatever we think provides our best possible docs experiences. Is there a way to render our docs site directly from the README so the two can't fall out of sync and so we don't need one to merely be a cross-reference to the other?

• jordansanders added a child revision: D8492: Use the EcsRunLauncher in the reference deployment.Jun 23 2021, 2:57 PM

• jordansanders added a parent revision: D8292: Add a reference deployment for ECS.

rebase

rebase

Harbormaster failed remote builds in B32495: Diff 40030!Jun 23 2021, 3:29 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2021, 3:37 PM

Harbormaster failed remote builds in B32508: Diff 40043!

Harbormaster failed remote builds in B32501: Diff 40036!Jun 23 2021, 3:48 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2021, 5:52 PM

Harbormaster failed remote builds in B32524: Diff 40067!

rebase

Harbormaster completed remote builds in B32542: Diff 40092.Jun 23 2021, 9:29 PM

• jordansanders requested review of this revision.Jun 23 2021, 9:29 PM

• dgibson accepted this revision.Jun 24 2021, 2:15 PM

• dgibson added subscribers: • yuhan, • sashank.

• dgibson added inline comments.

docs/content/deployment/guides/aws.mdx
16	@sashank or @yuhan may have opinions here, I do not
18	Not ECSRunLauncher yet right?

This revision is now accepted and ready to land.Jun 24 2021, 2:15 PM

Closed by commit R1:9122845e8e81: Cross-reference ECS reference deployment (authored by • jordansanders). · Explain WhyJun 24 2021, 3:37 PM

This revision was automatically updated to reflect the committed changes.

• jordansanders added a commit: R1:9122845e8e81: Cross-reference ECS reference deployment.

Revision Contents
Changeset List

Path

Size

docs/

content/

deployment/

guides/

6 lines

Diff 40134

docs/content/deployment/guides/aws.mdx

Loading...