Differential D8490

Remove reference to output_manager decorator
ClosedPublic
Actions

Authored by • jordansanders on Jun 22 2021, 6:02 PM.

Tags

None

Referenced Files

	F2882606: D8490.diff
	Tue, Mar 21, 5:42 PM

	F2882505: D8490.diff
	Tue, Mar 21, 3:37 PM

	Unknown Object (File)
	Fri, Mar 10, 11:05 PM

	Unknown Object (File)
	Sun, Feb 26, 4:14 PM

	Unknown Object (File)
	Sun, Feb 26, 8:14 AM

	Unknown Object (File)
	Thu, Feb 23, 11:23 AM

	Unknown Object (File)
	Feb 13 2023, 10:35 PM

	Unknown Object (File)
	Feb 10 2023, 7:25 PM

View All 44 Files

Subscribers

None

Details

Reviewers

• sandyryza
alangenfeld

Commits

R1:c2a85bca973e: Remove reference to output_manager decorator

Summary

This decorator was removed with the 0.10.0 release when we transitioned
from using OutputManagers directly to using IOManagers:

https://github.com/dagster-io/dagster/commit/3397d9c1eda139c81501d1157a3f72f9e9a334dc

But the remaining docstring caused some confusion in Slack:

https://dagster.slack.com/archives/C01U954MEER/p1624380774044300

Test Plan

unit

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jordansanders created this revision.Jun 22 2021, 6:02 PM

Harbormaster completed remote builds in B32491: Diff 40026.Jun 22 2021, 6:29 PM

• jordansanders requested review of this revision.Jun 22 2021, 6:29 PM

• jordansanders added inline comments.Jun 22 2021, 6:32 PM

python_modules/dagster/dagster/core/storage/output_manager.py
58	I wonder a) how much any of these docstrings remain useful and b) how much the OutputManager/InputManagers remain useful or if they should be folded into the IOManager base class.

given the inline comment ill let @sandyryza accept with any other insight on what should change around this

Did a user come across this? I didn't think we exposed OutputManager in our docs at all. I don't think we need it around anymore.

This revision is now accepted and ready to land.Jun 24 2021, 3:30 PM

In D8490#222107, @sandyryza wrote:

Did a user come across this? I didn't think we exposed OutputManager in our docs at all. I don't think we need it around anymore.

Yeah, a user asked about it https://dagster.slack.com/archives/C01U954MEER/p1624380774044300

Closed by commit R1:c2a85bca973e: Remove reference to output_manager decorator (authored by • jordansanders). · Explain WhyJun 30 2021, 7:31 PM

This revision was automatically updated to reflect the committed changes.

• jordansanders added a commit: R1:c2a85bca973e: Remove reference to output_manager decorator.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

dagster/

core/

storage/

output_manager.py

2 lines

Diff 40577

python_modules/dagster/dagster/core/storage/output_manager.py

Loading...