Page MenuHomeElementl

Remove reference to output_manager decorator
ClosedPublic

Authored by jordansanders on Jun 22 2021, 6:02 PM.
Tags
None
Referenced Files
F2434036: D8490.diff
Mon, Aug 15, 1:07 AM
Unknown Object (File)
Wed, Aug 10, 4:38 PM
Unknown Object (File)
Sun, Jul 31, 2:58 PM
Unknown Object (File)
Sat, Jul 16, 2:28 AM
Unknown Object (File)
Jul 16 2022, 1:27 AM
Unknown Object (File)
Jul 15 2022, 2:45 AM
Unknown Object (File)
Jul 15 2022, 2:45 AM
Unknown Object (File)
Jul 15 2022, 2:45 AM
Subscribers
None

Details

Summary

This decorator was removed with the 0.10.0 release when we transitioned
from using OutputManagers directly to using IOManagers:

https://github.com/dagster-io/dagster/commit/3397d9c1eda139c81501d1157a3f72f9e9a334dc

But the remaining docstring caused some confusion in Slack:

https://dagster.slack.com/archives/C01U954MEER/p1624380774044300

Test Plan

unit

Diff Detail

Repository
R1 dagster
Branch
jordan-fixup-docstring (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

python_modules/dagster/dagster/core/storage/output_manager.py
58

I wonder a) how much any of these docstrings remain useful and b) how much the OutputManager/InputManagers remain useful or if they should be folded into the IOManager base class.

given the inline comment ill let @sandyryza accept with any other insight on what should change around this

Did a user come across this? I didn't think we exposed OutputManager in our docs at all. I don't think we need it around anymore.

This revision is now accepted and ready to land.Jun 24 2021, 3:30 PM

Did a user come across this? I didn't think we exposed OutputManager in our docs at all. I don't think we need it around anymore.

Yeah, a user asked about it https://dagster.slack.com/archives/C01U954MEER/p1624380774044300