Page MenuHomePhabricator

Add systemd service for dagit
ClosedPublic

Authored by natekupp on Tue, Aug 20, 8:57 PM.

Details

Reviewers
schrockn
Group Reviewers
Restricted Project
Commits
R1:df1f097aa9a4: Add systemd service for dagit
Test Plan

Tested manually with dagster-aws up; make changes; dagster-aws up

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

natekupp updated this revision to Diff 3865.Tue, Aug 20, 8:57 PM
natekupp created this revision.

up

schrockn requested changes to this revision.EditedTue, Aug 20, 9:02 PM
schrockn added a subscriber: schrockn.

This is really exciting to see. Just have the question about restart latency.

python_modules/libraries/dagster-aws/dagster_aws/cli/shell/init.sh
46

why wait 3 seconds?

This revision now requires changes to proceed.Tue, Aug 20, 9:02 PM
natekupp added inline comments.Tue, Aug 20, 9:05 PM
python_modules/libraries/dagster-aws/dagster_aws/cli/shell/init.sh
46

good catch, leftover from when I was experimenting - will drop

natekupp updated this revision to Diff 3867.Tue, Aug 20, 9:05 PM

comments

schrockn accepted this revision.Tue, Aug 20, 9:07 PM

Exciting stuff. I barely know anything about systems-level linux issues, so I can't really give substantive feedback on high level stuff, but this all seems reasonable.

This revision is now accepted and ready to land.Tue, Aug 20, 9:07 PM
Harbormaster completed remote builds in B3096: Diff 3867.
This revision was automatically updated to reflect the committed changes.