Add 'set_dagster_home' flag to instance_for_test
ClosedPublic
Actions

Authored by • dgibson on Jun 18 2021, 8:16 PM.

Details

Reviewers

alangenfeld
• johann
• max
• sashank

Commits

R1:f152cbb98624: Add 'set_dagster_home' flag to instance_for_test

Summary

Example of where you might want this if you have a test that sets up two different instances and you want one to be the 'true' one that is returned when you set DagsterInstance.get()

Test Plan

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• dgibson created this revision.Jun 18 2021, 8:16 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 18 2021, 8:36 PM

Harbormaster failed remote builds in B32442: Diff 39961!

• dgibson published this revision for review.Jun 18 2021, 9:46 PM

Harbormaster completed remote builds in B32454: Diff 39973.Jun 18 2021, 10:07 PM

• johann accepted this revision.Jun 21 2021, 6:42 PM

• johann added inline comments.

python_modules/dagster/dagster/core/test_utils.py
114	ooh haven't used this before

This revision is now accepted and ready to land.Jun 21 2021, 6:42 PM

Closed by commit R1:f152cbb98624: Add 'set_dagster_home' flag to instance_for_test (authored by • dgibson). · Explain WhyJun 21 2021, 6:51 PM

This revision was automatically updated to reflect the committed changes.

• dgibson added a commit: R1:f152cbb98624: Add 'set_dagster_home' flag to instance_for_test.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

core/

test_utils.py

13 lines

Diff 40001

View Options

python_modules/dagster/dagster/core/test_utils.py

Add 'set_dagster_home' flag to instance_for_testClosedPublicActions