Differential D8474

Tag runs with ECS info
ClosedPublic
Actions

Authored by • jordansanders on Jun 18 2021, 8:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 13, 8:50 PM

	Unknown Object (File)
	Apr 17 2023, 9:54 PM

	Unknown Object (File)
	Apr 7 2023, 10:32 AM

	Unknown Object (File)
	Apr 6 2023, 6:18 AM

	Unknown Object (File)
	Apr 4 2023, 10:40 PM

	Unknown Object (File)
	Mar 20 2023, 10:11 PM

	Unknown Object (File)
	Mar 20 2023, 1:41 PM

	Unknown Object (File)
	Mar 19 2023, 6:12 PM

View All 79 Files

Subscribers

None

Details

Reviewers

alangenfeld
• dgibson

Commits

R1:6fe3738d59db: Tag runs with ECS info

Summary

By storing the ECS run id in run storage, we no longer need to list all
tasks to find one with a matching tag. We're still tagging the ECS task
with the dagster run id so it's clear why that task was created when
looking in AWS - eventually we might choose to add additional dagster
metadata as well.

Test Plan

unit

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Lint fix

• jordansanders added reviewers: alangenfeld, • dgibson.Jun 18 2021, 8:09 PM

• jordansanders added a parent revision: D8417: Mixin ConfigurableClass with EcsRunLauncher.

• jordansanders added a child revision: D8475: Include ENI infornmation in ECS task stubs.

Harbormaster failed remote builds in B32434: Diff 39953!Jun 18 2021, 8:24 PM

Harbormaster completed remote builds in B32436: Diff 39955.Jun 18 2021, 8:27 PM

• jordansanders requested review of this revision.Jun 18 2021, 8:27 PM

• dgibson accepted this revision.Jun 21 2021, 5:26 PM

This revision is now accepted and ready to land.Jun 21 2021, 5:26 PM

rebase

Harbormaster completed remote builds in B32483: Diff 40015.Jun 21 2021, 10:06 PM

Closed by commit R1:6fe3738d59db: Tag runs with ECS info (authored by • jordansanders). · Explain WhyJun 23 2021, 5:24 PM

This revision was automatically updated to reflect the committed changes.

• jordansanders added a commit: R1:6fe3738d59db: Tag runs with ECS info.

Revision Contents
Changeset List

Path

Size

python_modules/

libraries/

dagster-aws/

dagster_aws/

ecs/

52 lines

dagster_aws_tests/

ecs_tests/

test_launcher.py

39 lines

Diff 40060

python_modules/libraries/dagster-aws/dagster_aws/ecs/launcher.py

Loading...

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/test_launcher.py

Loading...