Ensure AWS unit tests never run against real AWS
ClosedPublic
Actions

Authored by • jordansanders on Jun 18 2021, 7:46 PM.

Details

Reviewers

alangenfeld
• dgibson

Commits

R1:8b8c658674b6: Ensure AWS unit tests never run against real AWS

Summary

Patch os.environ on every test in the suite with AWS_ACCESS_KEY_ID=test
and AWS_SECRET_ACCESS_KEY=test to make sure we never accidentally run
against real AWS credentials in unit tests.

This is in line with the recommendations from moto:

https://github.com/spulec/moto#how-do-i-avoid-tests-from-mutating-my-real-infrastructure

Test Plan

unit

Diff Detail

Repository

R1 dagster

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

• jordansanders created this revision.Jun 18 2021, 7:46 PM

rebase

Harbormaster completed remote builds in B32428: Diff 39947.Jun 18 2021, 8:10 PM

Harbormaster completed remote builds in B32430: Diff 39949.Jun 18 2021, 8:36 PM

• jordansanders requested review of this revision.Jun 18 2021, 8:36 PM

no HBO max issues for us

We don't have any end-to-end tests that connect to a real AWS instance? or are all those in integration_tests

This revision is now accepted and ready to land.Jun 18 2021, 9:53 PM

In D8473#221262, @dgibson wrote:

We don't have any end-to-end tests that connect to a real AWS instance? or are all those in integration_tests

Not in this test suite at least. As a matter of principle, I think they _should_ go in integration tests though (and it looks like that's probably already the case).

rebase

This revision was landed with ongoing or failed builds.Jun 21 2021, 10:03 PM

Closed by commit R1:8b8c658674b6: Ensure AWS unit tests never run against real AWS (authored by • jordansanders). · Explain Why

This revision was automatically updated to reflect the committed changes.

• jordansanders added a commit: R1:8b8c658674b6: Ensure AWS unit tests never run against real AWS.

Harbormaster completed remote builds in B32479: Diff 40011.Jun 21 2021, 10:23 PM