Page MenuHomeElementl

[dagit] Remove session-token header
ClosedPublic

Authored by dish on Jun 18 2021, 6:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 15, 10:30 AM
Unknown Object (File)
Sat, Mar 11, 12:17 AM
Unknown Object (File)
Fri, Mar 10, 2:30 AM
Unknown Object (File)
Thu, Mar 9, 12:39 AM
Unknown Object (File)
Tue, Mar 7, 12:50 AM
Unknown Object (File)
Sun, Feb 26, 3:09 PM
Unknown Object (File)
Thu, Feb 23, 6:10 AM
Unknown Object (File)
Tue, Feb 21, 7:08 PM
Subscribers
None

Details

Summary

Just use the value from the cookie -- we don't need the extra header after all.

Test Plan

Validated with dgibson. Commented out the code that set the session token header, and auth worked as desired.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Sounds good to me! This would break run attribution in the demo, right, since that tries to read the header (as a proof of concept for the prezi ask, I think?)

As a fix, we can probably just refactor the run attribution stuff in the backend to use the existing cookie instead?

This revision is now accepted and ready to land.Jun 18 2021, 7:06 PM
This revision was automatically updated to reflect the committed changes.