This diff adds support for supplying ins and outs as dictionary arguments
Details
Details
unit
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
unclear if inheritance is the way to go with In and Out once there is this behavior difference. Might be best to have a simple value object and interpret it in to the underlying def, maybe with a scheme like [1]
Getting the type inference to work on MultiOut might inform which path is preferable
| python_modules/dagster/dagster/core/definitions/output.py | ||
|---|---|---|
| 190–216 | [1] | |
| 316 | copy pasta | |
| python_modules/dagster/dagster_tests/core_tests/definitions_tests/decorators_tests/test_op.py | ||
| 45–156 | would still like to see the types that the inputs & outputs have resolved with here in these tests | |
| python_modules/dagster/dagster_tests/core_tests/definitions_tests/decorators_tests/test_op.py | ||
|---|---|---|
| 45–156 | input and output types are Any, unfortunately | |
Comment Actions
If we're going with the pure dict approach then no - but if we're not sure if we want to support dicts or lists, I think it makes sense to keep it for now.