Page MenuHomeElementl
Differential D8467

Bugfixes for dagits checking cookies on each request
ClosedPublic
Actions

Authored by • dgibson on Jun 18 2021, 6:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 21, 11:41 AM
Unknown Object (File)
Fri, Jun 17, 11:57 AM
Unknown Object (File)
Thu, Jun 16, 1:15 AM
Unknown Object (File)
Wed, Jun 15, 6:19 PM
Subscribers
None

Details

Reviewers
• dish
Commits
R1:29f8ccb20a59: Bugfixes for dagits checking cookies on each request
Summary

results of a debugging session with dish:

  • better error visualzation when search bootstrap query fails (at least if you're looking at the response in devtools)
  • fix bad typehint that that query was hitting
Test Plan

load dagit with cookie validation enabled

Diff Detail

Repository
R1 dagster
Branch
cookiefun (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
core/
src/
search/
types/
5 lines
python_modules/
dagster-graphql/
dagster_graphql/
implementation/
4 lines

Diff 39919

View Options

js_modules/dagit/packages/core/src/search/types/SearchBootstrapQuery.ts

Loading...
View Options

js_modules/dagit/packages/core/src/search/useRepoSearch.tsx

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/implementation/external.py

Loading...