Page MenuHomeElementl
Differential D8457

[dagit] Create AppCache via function
ClosedPublic
Actions

Authored by • dish on Jun 18 2021, 3:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 2, 12:47 AM
Unknown Object (File)
Nov 18 2022, 12:05 AM
Unknown Object (File)
Nov 18 2022, 12:05 AM
Unknown Object (File)
Nov 18 2022, 12:05 AM
Unknown Object (File)
Nov 14 2022, 2:23 PM
Unknown Object (File)
Nov 3 2022, 4:05 AM
Unknown Object (File)
Nov 2 2022, 6:08 AM
Unknown Object (File)
Nov 1 2022, 11:20 PM
View All 28 Files
Subscribers
None

Details

Reviewers
• bengotow
Commits
R1:1fb8b35e7eaa: [dagit] Create AppCache via function
Summary

Instead of exporting AppCache, export a createAppCache function. This allows ApolloTestProvider to use a separate cache for each test, which makes sense given that mocks can vary from test to test.

In a followup, clean up the AppCache export entirely.

Test Plan

Buildkite. Load Dagit, sanity check that things are behaving.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
app/
src/
6 lines
core/
src/
app/
70 lines
testing/
5 lines

Diff 39873

View Options

js_modules/dagit/packages/app/src/index.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/app/AppCache.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/testing/ApolloTestProvider.tsx

Loading...