Page MenuHomePhabricator

Add dagster-aws up EC2 syncing
ClosedPublic

Authored by natekupp on Tue, Aug 20, 5:55 PM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:59583c5212d7: Add dagster-aws up EC2 syncing
Summary

This adds a command to sync a local project path to a remote EC2 instance

Test Plan

dagster-aws init; dagster-aws up

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

natekupp created this revision.Tue, Aug 20, 5:55 PM
natekupp added a reviewer: Restricted Project.Tue, Aug 20, 5:57 PM
alangenfeld accepted this revision.Tue, Aug 20, 7:46 PM
alangenfeld added a subscriber: alangenfeld.
alangenfeld added inline comments.
python_modules/libraries/dagster-aws/dagster_aws/cli/cli.py
370–394

what are your thoughts on git repos? should we special case it?

380

this would feel much better to infer from .gitignore but if we dont require a repo not sure how we could do much better

drop .pyc files too?

python_modules/libraries/dagster-aws/dagster_aws/cli/shell/init.sh
3

/opt/ - what dis? i assume its a common practice i just dont know about

This revision is now accepted and ready to land.Tue, Aug 20, 7:46 PM
natekupp updated this revision to Diff 3860.Tue, Aug 20, 7:52 PM

comments

This revision was automatically updated to reflect the committed changes.