Page MenuHomeElementl

[helm][schema] Make HelmTemplate more generic
ClosedPublic

Authored by sidkmenon on Jun 17 2021, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 12, 6:54 AM
Unknown Object (File)
Fri, Aug 12, 6:53 AM
Unknown Object (File)
Fri, Aug 12, 6:52 AM
Unknown Object (File)
Thu, Aug 11, 6:04 PM
Unknown Object (File)
Wed, Aug 3, 11:32 AM
Unknown Object (File)
Tue, Jul 19, 12:11 PM
Unknown Object (File)
Sun, Jul 17, 12:26 PM
Unknown Object (File)
Sun, Jul 17, 5:20 AM
Subscribers
None

Details

Summary

For reusability in internal

Test Plan

bk

Diff Detail

Repository
R1 dagster
Branch
add-helm-schema (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

sidkmenon created this revision.
sidkmenon held this revision as a draft.

rebasing

Moving helm_dir_path and subchart_paths into the constructor of HelmTemplate

rexledesma added inline comments.
helm/dagster/schema/schema/utils/helm_template.py
28–29

I don't think these paths should have defaults - they should be explicitly passed in when this class is instantiated

This revision now requires changes to proceed.Jun 17 2021, 8:49 PM

requiring config of helm_dir_path & subchart_paths via @rexledesma's comments

helm/dagster/schema/schema/utils/helm_template.py
28–29

sure, that seems fair enough. Will do!

This revision is now accepted and ready to land.Jun 18 2021, 2:54 AM
sidkmenon added a child revision: Restricted Differential Revision.Jun 18 2021, 7:39 AM
This revision was landed with ongoing or failed builds.Jun 18 2021, 3:00 PM
This revision was automatically updated to reflect the committed changes.