Page MenuHomeElementl
Differential D8441

[helm][schema] Make HelmTemplate more generic
ClosedPublic
Actions

Authored by • sidkmenon on Jun 17 2021, 7:55 PM.

Details

Reviewers
rexledesma
Commits
R1:fc21a14324c2: [helm][schema] Make HelmTemplate more generic
Summary

For reusability in internal

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• sidkmenon updated this revision to Diff 39802.Jun 17 2021, 7:55 PM
• sidkmenon created this revision.

rebasing

• sidkmenon updated this revision to Diff 39810.Jun 17 2021, 8:13 PM

Moving helm_dir_path and subchart_paths into the constructor of HelmTemplate

Harbormaster completed remote builds in B32315: Diff 39802.Jun 17 2021, 8:23 PM
• sidkmenon published this revision for review.Jun 17 2021, 8:38 PM
Harbormaster failed remote builds in B32313: Diff 39800!Jun 17 2021, 8:39 PM
Harbormaster completed remote builds in B32322: Diff 39810.
rexledesma requested changes to this revision.Jun 17 2021, 8:49 PM
rexledesma added inline comments.
helm/dagster/schema/schema/utils/helm_template.py
28–29

I don't think these paths should have defaults - they should be explicitly passed in when this class is instantiated

This revision now requires changes to proceed.Jun 17 2021, 8:49 PM
• sidkmenon updated this revision to Diff 39827.Jun 17 2021, 9:26 PM

requiring config of helm_dir_path & subchart_paths via @rexledesma's comments

• sidkmenon added inline comments.Jun 17 2021, 9:29 PM
helm/dagster/schema/schema/utils/helm_template.py
28–29

sure, that seems fair enough. Will do!

Harbormaster failed remote builds in B32336: Diff 39827!Jun 17 2021, 9:46 PM
rexledesma accepted this revision.Jun 18 2021, 2:54 AM
This revision is now accepted and ready to land.Jun 18 2021, 2:54 AM
• sidkmenon added a child revision: Restricted Differential Revision.Jun 18 2021, 7:39 AM
This revision was landed with ongoing or failed builds.Jun 18 2021, 3:00 PM
Closed by commit R1:fc21a14324c2: [helm][schema] Make HelmTemplate more generic (authored by Sidharth Menon <menon.sid.k@gmail.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Sidharth Menon <menon.sid.k@gmail.com> added a commit: R1:fc21a14324c2: [helm][schema] Make HelmTemplate more generic.

Revision Contents
Changeset List

Diff 39861

View Options

helm/dagster/schema/schema/utils/__init__.py

Loading...
View Options

helm/dagster/schema/schema/utils/helm_template.py

Loading...
View Options

helm/dagster/schema/schema_tests/helm_template.py

Loading...
View Options

helm/dagster/schema/schema_tests/test_celery_queues.py

Loading...
View Options

helm/dagster/schema/schema_tests/test_dagit.py

Loading...
View Options

helm/dagster/schema/schema_tests/test_dagster_daemon.py

Loading...
View Options

helm/dagster/schema/schema_tests/test_ingress.py

Loading...
View Options

helm/dagster/schema/schema_tests/test_instance.py

Loading...
View Options

helm/dagster/schema/schema_tests/test_instance_migrate.py

Loading...
View Options

helm/dagster/schema/schema_tests/test_postgresql_secret.py

Loading...
View Options

helm/dagster/schema/schema_tests/test_service_account.py

Loading...
View Options

helm/dagster/schema/schema_tests/test_user_deployments.py

Loading...
View Options

helm/dagster/schema/schema_tests/test_workspace.py

Loading...