Page MenuHomeElementl

[helm][schema] Make HelmTemplate more generic
ClosedPublic

Authored by sidkmenon on Jun 17 2021, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 4, 4:27 AM
Unknown Object (File)
Sun, Oct 2, 1:10 AM
Unknown Object (File)
Fri, Sep 30, 1:02 AM
Unknown Object (File)
Wed, Sep 28, 1:03 AM
Unknown Object (File)
Mon, Sep 26, 12:54 AM
Unknown Object (File)
Wed, Sep 21, 9:41 AM
Unknown Object (File)
Mon, Sep 19, 8:58 AM
Unknown Object (File)
Sun, Sep 18, 7:02 PM
Subscribers
None

Details

Summary

For reusability in internal

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sidkmenon created this revision.
sidkmenon held this revision as a draft.

rebasing

Moving helm_dir_path and subchart_paths into the constructor of HelmTemplate

rexledesma added inline comments.
helm/dagster/schema/schema/utils/helm_template.py
28–29

I don't think these paths should have defaults - they should be explicitly passed in when this class is instantiated

This revision now requires changes to proceed.Jun 17 2021, 8:49 PM

requiring config of helm_dir_path & subchart_paths via @rexledesma's comments

helm/dagster/schema/schema/utils/helm_template.py
28–29

sure, that seems fair enough. Will do!

This revision is now accepted and ready to land.Jun 18 2021, 2:54 AM
sidkmenon added a child revision: Restricted Differential Revision.Jun 18 2021, 7:39 AM
This revision was landed with ongoing or failed builds.Jun 18 2021, 3:00 PM
This revision was automatically updated to reflect the committed changes.