Details

Reviewers

• rexledesma
• jordansanders

Commits

R1:c6178f86367d: [helm] Add k8s fields to pydantic schema

Summary

Adding more k8s fields to the pydantic schema, including InitContainers & VolumeMounts.

Test Plan

helm lint + bk

Diff Detail

Repository

R1 dagster

Lint

Lint Passed

Unit

No Test Coverage

• sidkmenon held this revision as a draft.

rebasing

• sidkmenon published this revision for review.Jun 17 2021, 9:09 PM

Also increase number of retires on helm checks since that appears to be a problem

helm/dagster/schema/schema/charts/utils/kubernetes.py
99–101	we shouldn't be adding fields to these classes - the point is that they exactly match the kubernetes object that they represent (as expressed through schema extra)

• sidkmenon added a child revision: Restricted Differential Revision.Jun 18 2021, 7:39 AM

responding to @rexledesma's comments

helm/dagster/schema/schema/charts/utils/kubernetes.py
99–101	Ah ok - I saw some classes with fields and some without, so wasn't sure. I'll remove them.

Addressing 'TODO'

helm/dagster/schema/schema/charts/utils/kubernetes.py
99–101	Decided to refrain from `schema_extra` here since `InitContainer` isn't supported by the JSON schema API we use - was thinking about trying to hand-roll some validation hooks to show the difference between this and `Container` but to keep things simple decided to just provide these fields for now.

• johann added inline comments.

.buildkite/dagster-buildkite/dagster_buildkite/steps/helm.py
51 ↗	(On Diff #39893)	What causes the flakes?

helm/dagster/schema/schema/charts/utils/kubernetes.py
99–101	Looks like they type `InitContainer` as `Container` in https://kubernetesjsonschema.dev/v1.15.0/_definitions.json - let's just use `Container` as the schema for `InitContainer` to keep it simple.