Page MenuHomePhabricator

Break up AWS CLI and add tests
ClosedPublic

Authored by natekupp on Mon, Aug 19, 11:40 PM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:ae5cac6272b8: Break up AWS CLI and add tests
Summary

This puts the dagster-aws CLI tool in the dagster-aws library; conceivably we may eventually have similar tools for GCP, Azure, etc. so it seems like this is a reasonable place, but open to other perspectives here!

Otherwise, main goal of this diff is breaking apart the monolithic script and adding tests for at least some of it.

Test Plan
  • unit
  • manual tested pip install -e ...; dagster-aws init; dagster-aws shell

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

natekupp created this revision.Mon, Aug 19, 11:40 PM
natekupp edited the summary of this revision. (Show Details)Mon, Aug 19, 11:46 PM
natekupp added a reviewer: Restricted Project.
natekupp updated this revision to Diff 3837.Tue, Aug 20, 12:09 AM

add checks

so this takes care of everything so its just pip install dagster-aws; dagster-aws; (include in test plan)?

python_modules/libraries/dagster-aws/setup.py
43

neato

alangenfeld accepted this revision.Tue, Aug 20, 12:13 AM
This revision is now accepted and ready to land.Tue, Aug 20, 12:13 AM
natekupp edited the test plan for this revision. (Show Details)Tue, Aug 20, 3:23 AM
This revision was automatically updated to reflect the committed changes.