Page MenuHomeElementl
Differential D8423

rename StoredEventRecord -> EventLogRecord
ClosedPublic
Actions

Authored by • yuhan on Jun 16 2021, 11:20 PM.
Tags
None
Referenced Files
F2989914: D8423.id39891.diff
Thu, Jun 8, 2:38 PM
Unknown Object (File)
Sun, May 21, 12:06 PM
Unknown Object (File)
Thu, May 18, 5:58 PM
Unknown Object (File)
Thu, May 18, 12:58 PM
Unknown Object (File)
May 1 2023, 6:13 AM
Unknown Object (File)
Mar 26 2023, 8:33 AM
Unknown Object (File)
Mar 19 2023, 2:20 AM
Unknown Object (File)
Mar 16 2023, 1:14 PM
View All 52 Files
Subscribers
None

Details

Reviewers
• prha
alangenfeld
Commits
R1:fa16b017596c: rename StoredEventRecord -> EventLogRecord
Summary

depends on D8422

Test Plan

bk
pipeline failure sensor works

Diff Detail

Repository
R1 dagster
Branch
arcpatch-D8213
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• yuhan created this revision.Jun 16 2021, 11:20 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 17 2021, 12:05 AM
Harbormaster failed remote builds in B32259: Diff 39730!
• yuhan requested review of this revision.Jun 17 2021, 1:01 AM

test green

• yuhan added a child revision: Restricted Differential Revision.Jun 17 2021, 1:17 AM
• prha mentioned this in D8422: rename EventRecord -> EventLogEntry.Jun 17 2021, 4:17 AM
• prha requested changes to this revision.Jun 17 2021, 2:23 PM

Would feel more comfortable with this being EventLogRecord (as per the discussion in D8422)

This revision now requires changes to proceed.Jun 17 2021, 2:23 PM
• yuhan retitled this revision from rename StoredEventRecord -> EventRecord to rename StoredEventRecord -> EventLogRecord.Jun 17 2021, 8:50 PM
• yuhan updated this revision to Diff 39818.Jun 17 2021, 8:52 PM
• yuhan retitled this revision from rename StoredEventRecord -> EventLogRecord to rename StoredEventRecord -> EventRecord.

EventLogRecord

Harbormaster failed remote builds in B32330: Diff 39818!Jun 17 2021, 9:13 PM
• prha accepted this revision.Jun 17 2021, 9:25 PM
This revision is now accepted and ready to land.Jun 17 2021, 9:25 PM
• yuhan retitled this revision from rename StoredEventRecord -> EventRecord to rename StoredEventRecord -> EventLogRecord.Jun 17 2021, 9:26 PM
This revision was landed with ongoing or failed builds.Jun 18 2021, 5:10 PM
Closed by commit R1:fa16b017596c: rename StoredEventRecord -> EventLogRecord (authored by • yuhan). · Explain Why
This revision was automatically updated to reflect the committed changes.
• yuhan added a commit: R1:fa16b017596c: rename StoredEventRecord -> EventLogRecord.

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
core/
storage/
event_log/
4 lines
4 lines
4 lines
sqlite/
4 lines

Diff 39818

View Options

python_modules/dagster/dagster/core/storage/event_log/base.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/event_log/in_memory.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/event_log/sql_event_log.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/event_log/sqlite/sqlite_event_log.py

Loading...