Paths

Table of Contentst

Differential D8422

rename EventRecord -> EventLogEntry
ClosedPublic
Actions

Authored by yuhan on Jun 16 2021, 11:07 PM.

Tags

None

Subscribers

None

Details

Reviewers

prha
alangenfeld

Commits

R1:50c85a8dfb1c: rename EventRecord -> EventLogEntry

Summary

depends on D8418
rename EventRecord to EventLogEntry
register_serdes_tuple_fallbacks seems to handle everything - except the cases when dagit or daemon is running older versions, which we will have to ask users to redeploy to pick up the serdes backcompt.

Test Plan

bk
dagit loads
historical runs load
pipeline failure sensors works

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuhan created this revision.Jun 16 2021, 11:07 PM

yuhan added a child revision: D8423: rename StoredEventRecord -> EventLogRecord.Jun 16 2021, 11:20 PM

yuhan added reviewers: prha, alangenfeld.Jun 16 2021, 11:21 PM

Harbormaster completed remote builds in B32258: Diff 39729.Jun 16 2021, 11:34 PM

yuhan requested review of this revision.Jun 16 2021, 11:34 PM

prha added inline comments.Jun 17 2021, 4:17 AM

python_modules/dagster/dagster/core/events/log.py
174	I'm a little worried about this with https://dagster.phacility.com/D8423.... I know that the new EventRecord is not marked for serdes currently, but I could see this being a pretty big gotcha down the road. Does the fact that the `typename` of the original `EventRecord` definition is `_EventRecord` help disambiguate at all?

yuhan added inline comments.Jun 17 2021, 4:55 AM

python_modules/dagster/dagster/core/events/log.py
174	that's right.. i don't think the `typename` will make any difference since we don't really persist that. even it does, the gotcha will still be there and instead become "dont set the new EventRecord's typename to be _EventRecord". I didn't see a good way to avoid all caveat if we decide to reuse the same name. I guess an alternative name for D8423 is `EventLogRecord` which is a bit verbose but actually does pair with "EventLogStorage" (as for "RunRecord" to "RunStorage").

prha accepted this revision.Jun 17 2021, 2:21 PM

prha added inline comments.

python_modules/dagster/dagster/core/events/log.py
174	👍

This revision is now accepted and ready to land.Jun 17 2021, 2:21 PM

prha mentioned this in D8423: rename StoredEventRecord -> EventLogRecord.Jun 17 2021, 2:23 PM

Closed by commit R1:50c85a8dfb1c: rename EventRecord -> EventLogEntry (authored by yuhan). · Explain WhyJun 18 2021, 5:09 PM

This revision was automatically updated to reflect the committed changes.

yuhan added a commit: R1:50c85a8dfb1c: rename EventRecord -> EventLogEntry.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster-graphql/

dagster_graphql/

implementation/

8 lines

schema/

pipelines/

4 lines

dagster_graphql_tests/

graphql/

snapshots/

snap_test_assets.py

snap_test_composites.py

snap_test_compute_logs.py

test_pipeline_run_observable_subscribe_with_polling.py

4 lines

dagster/

dagster/

core/

4 lines

events/

18 lines

execution/

plan/

6 lines

6 lines

instance/

20 lines

run_coordinator/

queued_run_coordinator.py

4 lines

storage/

event_log/

12 lines

4 lines

4 lines

polling_event_watcher.py

34 lines

sql_event_log.py

28 lines

sqlite/

sqlite_event_log.py

10 lines

daemon/

run_coordinator/

queued_run_coordinator_daemon.py

4 lines

dagster_tests/

core_tests/

execution_tests/

test_api_iterators.py

10 lines

resource_tests/

test_resource_definition.py

6 lines

storage_tests/

6 lines

test_polling_event_watcher.py

8 lines

utils/

event_log_storage.py

30 lines

test_event_logging.py

4 lines

general_tests/

compat_tests/

test_back_compat.py

11 lines

libraries/

dagster-airflow/

dagster_airflow_tests/

test_factory/

4 lines

dagster-celery-k8s/

dagster_celery_k8s/

4 lines

dagster-mysql/

dagster_mysql/

event_log/

4 lines

dagster-postgres/

dagster_postgres/

event_log/

14 lines

dagstermill/

dagstermill_tests/

test_event_callback.py

4 lines

Diff 39890

python_modules/dagster-graphql/dagster_graphql/implementation/events.py

Loading...

python_modules/dagster-graphql/dagster_graphql/schema/pipelines/pipeline.py

Loading...

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_assets.py

Loading...

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_composites.py

Loading...

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_compute_logs.py

Loading...

python_modules/dagster-graphql/dagster_graphql_tests/test_pipeline_run_observable_subscribe_with_polling.py

Loading...

python_modules/dagster/dagster/core/debug.py

Loading...

python_modules/dagster/dagster/core/events/log.py

Loading...

python_modules/dagster/dagster/core/execution/plan/state.py

Loading...

python_modules/dagster/dagster/core/execution/stats.py

Loading...

python_modules/dagster/dagster/core/instance/init.py

Loading...

python_modules/dagster/dagster/core/run_coordinator/queued_run_coordinator.py

Loading...

python_modules/dagster/dagster/core/storage/event_log/base.py

Loading...

python_modules/dagster/dagster/core/storage/event_log/in_memory.py

Loading...

python_modules/dagster/dagster/core/storage/event_log/migration.py

Loading...

python_modules/dagster/dagster/core/storage/event_log/polling_event_watcher.py

Loading...

python_modules/dagster/dagster/core/storage/event_log/sql_event_log.py

Loading...

python_modules/dagster/dagster/core/storage/event_log/sqlite/sqlite_event_log.py

Loading...

python_modules/dagster/dagster/daemon/run_coordinator/queued_run_coordinator_daemon.py

Loading...

python_modules/dagster/dagster_tests/core_tests/execution_tests/test_api_iterators.py

Loading...

python_modules/dagster/dagster_tests/core_tests/resource_tests/test_resource_definition.py

Loading...

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_assets.py

Loading...

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_polling_event_watcher.py

Loading...

python_modules/dagster/dagster_tests/core_tests/storage_tests/utils/event_log_storage.py

Loading...

python_modules/dagster/dagster_tests/core_tests/test_event_logging.py

Loading...

python_modules/dagster/dagster_tests/general_tests/compat_tests/test_back_compat.py

Loading...

python_modules/libraries/dagster-airflow/dagster_airflow_tests/test_factory/utils.py

Loading...

python_modules/libraries/dagster-celery-k8s/dagster_celery_k8s/executor.py

Loading...

python_modules/libraries/dagster-mysql/dagster_mysql/event_log/event_log.py

Loading...

python_modules/libraries/dagster-postgres/dagster_postgres/event_log/event_log.py

Loading...

python_modules/libraries/dagstermill/dagstermill_tests/test_event_callback.py

Loading...