Page MenuHomeElementl
Differential D8418

get_event_rows -> get_event_records
ClosedPublic
Actions

Authored by • yuhan on Jun 16 2021, 8:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 27, 12:34 AM
Unknown Object (File)
Mon, May 15, 2:08 AM
Unknown Object (File)
Apr 15 2023, 6:53 PM
Unknown Object (File)
Mar 31 2023, 11:53 PM
Unknown Object (File)
Mar 23 2023, 9:02 PM
Unknown Object (File)
Mar 18 2023, 12:40 PM
Unknown Object (File)
Mar 18 2023, 8:05 AM
Unknown Object (File)
Mar 18 2023, 8:00 AM
View All 50 Files
Subscribers
None

Details

Reviewers
• prha
alangenfeld
Commits
R1:c8d7318ce118: get_event_rows -> get_event_records
Summary

depends on D8213

  • get_event_rows -> get_event_records
  • add StoredEventRecord (will later be EventRecord after we rename EventRecord -> EventLogEntry)
  • RunRecord.record_id -> RunRecord.storage_id

next:

  • EventRecord -> EventLogEntry
  • StoredEventRecord -> EventRecord
Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• yuhan created this revision.Jun 16 2021, 8:55 PM
• yuhan updated this revision to Diff 39717.Jun 16 2021, 9:35 PM

up

• yuhan edited the summary of this revision. (Show Details)Jun 16 2021, 9:38 PM
• yuhan added a parent revision: D8213: pipeline sensor - fetch events without run id + sqlite trick.
Harbormaster failed remote builds in B32245: Diff 39713!Jun 16 2021, 9:41 PM
Harbormaster completed remote builds in B32247: Diff 39717.Jun 16 2021, 10:03 PM
• yuhan requested review of this revision.Jun 16 2021, 10:03 PM
• yuhan updated this revision to Diff 39728.Jun 16 2021, 10:50 PM

up

• yuhan edited the test plan for this revision. (Show Details)Jun 16 2021, 10:55 PM
• yuhan edited the summary of this revision. (Show Details)
• yuhan edited the test plan for this revision. (Show Details)
• yuhan added a child revision: D8422: rename EventRecord -> EventLogEntry.Jun 16 2021, 11:07 PM
Harbormaster completed remote builds in B32257: Diff 39728.Jun 16 2021, 11:16 PM
• yuhan added reviewers: • prha, alangenfeld.Jun 16 2021, 11:20 PM
• prha accepted this revision.Jun 17 2021, 5:32 PM
This revision is now accepted and ready to land.Jun 17 2021, 5:32 PM
Closed by commit R1:c8d7318ce118: get_event_rows -> get_event_records (authored by • yuhan). · Explain WhyJun 18 2021, 5:08 PM
This revision was automatically updated to reflect the committed changes.
• yuhan added a commit: R1:c8d7318ce118: get_event_rows -> get_event_records.
• yuhan mentioned this in D8324: get_stored_events and get_stored_runs.Jun 18 2021, 5:09 PM

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
core/
definitions/
22 lines
storage/
event_log/
13 lines
14 lines
12 lines
sqlite/
11 lines
2 lines
runs/
2 lines
dagster_tests/
core_tests/
storage_tests/
utils/
49 lines

Diff 39889

View Options

python_modules/dagster/dagster/core/definitions/pipeline_sensor.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/event_log/base.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/event_log/in_memory.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/event_log/sql_event_log.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/event_log/sqlite/sqlite_event_log.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/pipeline_run.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/runs/sql_run_storage.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/utils/event_log_storage.py

Loading...