Page MenuHomeElementl
Differential D8417

Mixin ConfigurableClass with EcsRunLauncher
ClosedPublic
Actions

Authored by • jordansanders on Jun 16 2021, 7:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 30, 1:57 PM
Unknown Object (File)
Apr 10 2023, 12:52 PM
Unknown Object (File)
Apr 9 2023, 4:07 AM
Unknown Object (File)
Apr 8 2023, 1:01 PM
Unknown Object (File)
Apr 6 2023, 2:46 AM
Unknown Object (File)
Apr 3 2023, 7:38 AM
Unknown Object (File)
Apr 3 2023, 7:38 AM
Unknown Object (File)
Apr 2 2023, 7:11 PM
View All Files
Subscribers
None

Details

Reviewers
alangenfeld
• dgibson
• johann
Commits
R1:e28f1b83c703: Mixin ConfigurableClass with EcsRunLauncher
Summary

There's not yet anything to configure - a subsequent diff will make the
boto3 client configurable.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jordansanders created this revision.Jun 16 2021, 7:50 PM
• jordansanders added a parent revision: D8405: Terminate ECS runs.Jun 16 2021, 7:51 PM
• jordansanders updated this revision to Diff 39709.Jun 16 2021, 8:03 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 8:35 PM
Harbormaster failed remote builds in B32228: Diff 39696!
Harbormaster failed remote builds in B32241: Diff 39709!
• jordansanders updated this revision to Diff 39758.Jun 17 2021, 2:37 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 17 2021, 3:02 PM
Harbormaster failed remote builds in B32281: Diff 39758!
• jordansanders updated this revision to Diff 39769.Jun 17 2021, 3:12 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 17 2021, 3:37 PM
Harbormaster failed remote builds in B32291: Diff 39769!
• jordansanders updated this revision to Diff 39807.Jun 17 2021, 8:06 PM

rebase

• jordansanders updated this revision to Diff 39808.Jun 17 2021, 8:07 PM

rebase

• jordansanders updated this revision to Diff 39815.Jun 17 2021, 8:23 PM

Remove unused import

Harbormaster failed remote builds in B32321: Diff 39808!Jun 17 2021, 8:29 PM
Harbormaster completed remote builds in B32327: Diff 39815.Jun 17 2021, 8:46 PM
• jordansanders requested review of this revision.Jun 17 2021, 8:46 PM
Harbormaster failed remote builds in B32320: Diff 39807!Jun 17 2021, 8:48 PM
• dgibson accepted this revision.Jun 17 2021, 10:25 PM
This revision is now accepted and ready to land.Jun 17 2021, 10:25 PM
• jordansanders updated this revision to Diff 39952.Jun 18 2021, 8:01 PM

rebase

• jordansanders added a child revision: D8474: Tag runs with ECS info.Jun 18 2021, 8:10 PM
Harbormaster completed remote builds in B32433: Diff 39952.Jun 18 2021, 8:47 PM
• jordansanders updated this revision to Diff 40014.Jun 21 2021, 9:40 PM

rebase

Harbormaster completed remote builds in B32482: Diff 40014.Jun 21 2021, 10:06 PM
Closed by commit R1:e28f1b83c703: Mixin ConfigurableClass with EcsRunLauncher (authored by • jordansanders). · Explain WhyJun 23 2021, 5:24 PM
This revision was automatically updated to reflect the committed changes.
• jordansanders added a commit: R1:e28f1b83c703: Mixin ConfigurableClass with EcsRunLauncher.

Revision Contents
Changeset List

PathSize
python_modules/
libraries/
dagster-aws/
dagster_aws/
ecs/
21 lines
dagster_aws_tests/
ecs_tests/
16 lines

Diff 40059

View Options

python_modules/libraries/dagster-aws/dagster_aws/ecs/launcher.py

Loading...
View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/test_launcher.py

Loading...