Details

Reviewers

• sashank
jordansanders

Commits

R1:253088ea5a6f: 1/ load versioned mdx files from s3 instead of local .versioned_content folder

Summary

when building static pages, instead of reading from .versioned_content folder, this diff loads versioned content from s3.

next steps:

versioned images
update the release pipeline (or update version script) to upload versioned content to s3 instead of checking in to the repo
remove versioned_content and versioned_images
update release to skip rc version

Test Plan

preview

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuhan created this revision.Jun 16 2021, 6:14 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 6:57 PM

Harbormaster failed remote builds in B32209: Diff 39675!

add aws env vars to bk

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 17 2021, 10:00 PM

Harbormaster failed remote builds in B32340: Diff 39831!

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 17 2021, 10:29 PM

Harbormaster failed remote builds in B32346: Diff 39838!

jordansanders added a subscriber: jordansanders.Jun 18 2021, 5:45 PM

jordansanders added inline comments.

docs/next/pages/[...page].tsx
272	If we don't pass the credentials argument here, it should read them from wherever the credentials provider hits. When running on buildkite (on ec2), that'll be the instance profile. When running locally, that'll either be an envvar or an ~/.aws/credentials file (depending on how people have it set up). https://docs.aws.amazon.com/sdk-for-javascript/v3/developer-guide/setting-credentials-node.html In general, I think using instance profiles is a better strategy for providing credentials because it removes the risk or leaking secrets when set as envvars.

when remote content isn't available, fall back to the local content (i.e. master version)

Harbormaster failed remote builds in B32700: Diff 40280!Jun 26 2021, 2:37 AM

Harbormaster completed remote builds in B32701: Diff 40281.Jun 26 2021, 2:41 AM

yuhan requested review of this revision.Jun 26 2021, 2:41 AM

make s3 bucket public readonly - content serving website should just be public readble

Harbormaster completed remote builds in B32702: Diff 40282.Jun 26 2021, 4:08 AM

yuhan retitled this revision from load versioned mdx files from s3 instead of local .versioned_content folder to 1/ load versioned mdx files from s3 instead of local .versioned_content folder.Jun 28 2021, 6:43 AM

yuhan added a child revision: D8558: 2/ load versioned images from public s3 bucket.Jun 28 2021, 6:44 AM

yuhan edited the summary of this revision. (Show Details)Jun 28 2021, 6:11 PM

yuhan added reviewers: • sashank, jordansanders.

jordansanders resigned from this revision.Jun 29 2021, 3:02 PM

• sashank accepted this revision.Jun 29 2021, 3:55 PM

This revision is now accepted and ready to land.Jun 29 2021, 3:55 PM

Closed by commit R1:253088ea5a6f: 1/ load versioned mdx files from s3 instead of local .versioned_content folder (authored by yuhan). · Explain WhyJun 29 2021, 4:12 PM

This revision was automatically updated to reflect the committed changes.

yuhan added a commit: R1:253088ea5a6f: 1/ load versioned mdx files from s3 instead of local .versioned_content folder.