Pushes implementation of run storage down to dagster level. Will disentangle the inheritance in a follow-on diff.
- Group Reviewers
- R1:8a2e2fcbc437: Consolidate double implementation of run storage
This is a solid step forward. I'd love for you to comment on this diff re: what next steps are in terms of reining it in. I assume we want to get rid of the PipelineRun hierarchy?
class FilesystemRunStorage(InMemoryRunStorage): also seems very dubious.
I'm going to let alex accept this as he's been the primary reviewer.
seems like this should be its own change
I don't really think we should be trying to make somethink like RunStorage act like a python built-in
I think this might be worth using __slots__ because we might end up dealing with quite a few of these in memory
this method seems of dubious value. why not have clients construct this directly?