Page MenuHomeElementl
Differential D8407

Remove unused ECS Client
ClosedPublic
Actions

Authored by • jordansanders on Jun 16 2021, 4:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 30, 2:11 AM
Unknown Object (File)
Sun, May 28, 5:04 AM
Unknown Object (File)
Sun, May 21, 10:34 AM
Unknown Object (File)
Sat, May 20, 3:14 AM
Unknown Object (File)
Apr 29 2023, 2:04 AM
Unknown Object (File)
Apr 1 2023, 8:55 PM
Unknown Object (File)
Mar 31 2023, 1:04 AM
Unknown Object (File)
Mar 20 2023, 10:30 AM
View All Files
Subscribers
None

Details

Reviewers
alangenfeld
• dgibson
• johann
Commits
R1:678d816ae168: Remove unused ECS Client
Summary

This was created before the EcsRunLauncher and it turned out I didn't
need it.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jordansanders created this revision.Jun 16 2021, 4:08 PM
• jordansanders added a parent revision: D8405: Terminate ECS runs.Jun 16 2021, 4:10 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 4:35 PM
Harbormaster failed remote builds in B32174: Diff 39635!
• jordansanders updated this revision to Diff 39670.Jun 16 2021, 5:44 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 6:11 PM
Harbormaster failed remote builds in B32204: Diff 39670!
• jordansanders updated this revision to Diff 39690.Jun 16 2021, 7:24 PM

rebase

• jordansanders removed a parent revision: D8405: Terminate ECS runs.Jun 16 2021, 7:51 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 7:58 PM
Harbormaster failed remote builds in B32222: Diff 39690!
• jordansanders updated this revision to Diff 39708.Jun 16 2021, 8:02 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 8:32 PM
Harbormaster failed remote builds in B32240: Diff 39708!
• jordansanders updated this revision to Diff 39757.Jun 17 2021, 2:36 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 17 2021, 3:01 PM
Harbormaster failed remote builds in B32280: Diff 39757!
• jordansanders updated this revision to Diff 39768.Jun 17 2021, 3:11 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 17 2021, 3:33 PM
Harbormaster failed remote builds in B32290: Diff 39768!
• jordansanders updated this revision to Diff 39806.Jun 17 2021, 8:06 PM

rebase

• jordansanders updated this revision to Diff 39814.Jun 17 2021, 8:23 PM

rebase

Harbormaster completed remote builds in B32326: Diff 39814.Jun 17 2021, 8:48 PM
• jordansanders requested review of this revision.Jun 17 2021, 8:48 PM
Harbormaster completed remote builds in B32319: Diff 39806.Jun 17 2021, 8:49 PM
• dgibson accepted this revision.Jun 17 2021, 10:25 PM
This revision is now accepted and ready to land.Jun 17 2021, 10:25 PM
• jordansanders updated this revision to Diff 39946.Jun 18 2021, 7:45 PM

Reorder commits

• jordansanders updated this revision to Diff 39948.Jun 18 2021, 7:53 PM

rebase

Harbormaster completed remote builds in B32427: Diff 39946.Jun 18 2021, 8:12 PM
Harbormaster completed remote builds in B32429: Diff 39948.Jun 18 2021, 8:16 PM
• jordansanders updated this revision to Diff 40010.Jun 21 2021, 9:35 PM

rebase

Harbormaster completed remote builds in B32478: Diff 40010.Jun 21 2021, 10:01 PM
Closed by commit R1:678d816ae168: Remove unused ECS Client (authored by • jordansanders). · Explain WhyJun 21 2021, 10:03 PM
This revision was automatically updated to reflect the committed changes.
• jordansanders added a commit: R1:678d816ae168: Remove unused ECS Client.

Revision Contents
Changeset List

PathSize
python_modules/
libraries/
dagster-aws/
dagster_aws/
ecs/
dagster_aws_tests/
ecs_tests/

Diff 40021

View Options

python_modules/libraries/dagster-aws/dagster_aws/ecs/client.py

Loading...
View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/test_client.py

Loading...