unit
Details
Diff Detail
- Repository
- R1 dagster
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/test_launcher.py | ||
---|---|---|
87–94 | this is all still just stubbed right? termination is tricky to get right, would be nice to get some coverage that sees if it works in a real ECS environment. Did you test manually terminating against a real ECS task? |
python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/test_launcher.py | ||
---|---|---|
87–94 | Correct. What I plan to do is use the stubs for actual development/unit testing with a faster iteration loop but then add a higher level end-to-end test that runs against real ECS. It'll docker-compose up a daemon and a user code repository onto ECS (which will scaffold all the ECS resources with tags), run a pipeline, and check that it worked. We can also run a longer-running pipeline and test termination. And then it'll docker-compose down. I don't want to start with this approach though for a few reasons (that all more or less get summed up as "garbage collection"):
|