Page MenuHomeElementl
Differential D8403

Stub ECS StopTask
ClosedPublic
Actions

Authored by • jordansanders on Jun 16 2021, 4:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 12 2023, 4:20 PM
Unknown Object (File)
Apr 11 2023, 12:47 PM
Unknown Object (File)
Apr 10 2023, 2:55 AM
Unknown Object (File)
Apr 7 2023, 4:51 PM
Unknown Object (File)
Apr 4 2023, 6:28 AM
Unknown Object (File)
Apr 2 2023, 8:52 AM
Unknown Object (File)
Apr 1 2023, 2:38 PM
Unknown Object (File)
Apr 1 2023, 11:23 AM
View All Files
Subscribers
None

Details

Reviewers
alangenfeld
• dgibson
• johann
Commits
R1:0c2dfc3f7760: Stub ECS StopTask
Summary

https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_StopTask.html

Unlike the real endpoint which allows for some shutdown time to respond
to SIGTERM, this immediately switches the lastStatus to STOPPED.

The real ECS eventaully garbage collects stopped tasks so they'll no
longer appear in things like ListTasks; our stubbed ECS does not.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jordansanders created this revision.Jun 16 2021, 4:05 PM
• jordansanders added a parent revision: D8402: Stub ECS ListTagsForResource for tasks only.Jun 16 2021, 4:10 PM
• jordansanders added a child revision: D8404: Launch runs in ECS.
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 4:31 PM
Harbormaster failed remote builds in B32169: Diff 39629!
• jordansanders updated this revision to Diff 39667.Jun 16 2021, 5:43 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 6:13 PM
Harbormaster failed remote builds in B32201: Diff 39667!
• jordansanders updated this revision to Diff 39687.Jun 16 2021, 7:23 PM

rebase

• jordansanders updated this revision to Diff 39705.Jun 16 2021, 8:01 PM

rebase

Harbormaster failed remote builds in B32219: Diff 39687!Jun 16 2021, 8:08 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 8:30 PM
Harbormaster failed remote builds in B32237: Diff 39705!
• jordansanders updated this revision to Diff 39754.Jun 17 2021, 2:35 PM

rebase

Harbormaster completed remote builds in B32277: Diff 39754.Jun 17 2021, 3:02 PM
• jordansanders requested review of this revision.Jun 17 2021, 3:02 PM
• dgibson accepted this revision.Jun 17 2021, 10:15 PM
This revision is now accepted and ready to land.Jun 17 2021, 10:15 PM
• jordansanders mentioned this in D8404: Launch runs in ECS.Jun 18 2021, 2:01 PM
Closed by commit R1:0c2dfc3f7760: Stub ECS StopTask (authored by • jordansanders). · Explain WhyJun 18 2021, 7:25 PM
This revision was automatically updated to reflect the committed changes.
• jordansanders added a commit: R1:0c2dfc3f7760: Stub ECS StopTask.

Revision Contents
Changeset List

PathSize
python_modules/
libraries/
dagster-aws/
dagster_aws_tests/
ecs_tests/
21 lines
17 lines

Diff 39942

View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/stubbed_ecs.py

Loading...
View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/test_stubbed_ecs.py

Loading...