Page MenuHomeElementl
Differential D8402

Stub ECS ListTagsForResource for tasks only
ClosedPublic
Actions

Authored by • jordansanders on Jun 16 2021, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 1, 1:59 AM
Unknown Object (File)
Sat, May 20, 1:48 PM
Unknown Object (File)
Apr 28 2023, 3:26 AM
Unknown Object (File)
Apr 3 2023, 4:17 AM
Unknown Object (File)
Apr 2 2023, 4:52 AM
Unknown Object (File)
Apr 1 2023, 2:13 AM
Unknown Object (File)
Mar 28 2023, 6:30 AM
Unknown Object (File)
Mar 24 2023, 12:35 PM
View All 97 Files
Subscribers
None

Details

Reviewers
alangenfeld
• dgibson
• johann
Commits
R1:c66fc5aea00e: Stub ECS ListTagsForResource for tasks only
Summary

https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_ListTagsForResource.html

The EcsRunLauncher will tag each task with the run_id so it can
identify them. Until there's a need to tag other types of resources
(clusters, task definitions, etc.), this stubbed endpoint will only
work for tasks.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jordansanders created this revision.Jun 16 2021, 4:04 PM
• jordansanders added a parent revision: D8401: Stub ECS TagResource for tasks only.Jun 16 2021, 4:10 PM
• jordansanders added a child revision: D8403: Stub ECS StopTask.
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 4:30 PM
Harbormaster failed remote builds in B32168: Diff 39628!
• jordansanders updated this revision to Diff 39666.Jun 16 2021, 5:43 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 6:10 PM
Harbormaster failed remote builds in B32200: Diff 39666!
• jordansanders updated this revision to Diff 39686.Jun 16 2021, 7:23 PM

rebase

• jordansanders updated this revision to Diff 39704.Jun 16 2021, 8:01 PM

rebase

Harbormaster failed remote builds in B32218: Diff 39686!Jun 16 2021, 8:06 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 8:30 PM
Harbormaster failed remote builds in B32236: Diff 39704!
• jordansanders updated this revision to Diff 39753.Jun 17 2021, 2:34 PM

rebase

Harbormaster completed remote builds in B32276: Diff 39753.Jun 17 2021, 3:01 PM
• jordansanders requested review of this revision.Jun 17 2021, 3:01 PM
• dgibson accepted this revision.Jun 17 2021, 10:14 PM
This revision is now accepted and ready to land.Jun 17 2021, 10:14 PM
Closed by commit R1:c66fc5aea00e: Stub ECS ListTagsForResource for tasks only (authored by • jordansanders). · Explain WhyJun 18 2021, 7:25 PM
This revision was automatically updated to reflect the committed changes.
• jordansanders added a commit: R1:c66fc5aea00e: Stub ECS ListTagsForResource for tasks only.

Revision Contents
Changeset List

PathSize
python_modules/
libraries/
dagster-aws/
dagster_aws_tests/
ecs_tests/
19 lines
17 lines

Diff 39941

View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/stubbed_ecs.py

Loading...
View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/test_stubbed_ecs.py

Loading...