Page MenuHomeElementl
Differential D8401

Stub ECS TagResource for tasks only
ClosedPublic
Actions

Authored by • jordansanders on Jun 16 2021, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 2, 3:36 AM
Unknown Object (File)
Fri, May 19, 7:42 AM
Unknown Object (File)
Apr 11 2023, 7:10 PM
Unknown Object (File)
Apr 9 2023, 4:57 PM
Unknown Object (File)
Apr 6 2023, 7:51 AM
Unknown Object (File)
Apr 2 2023, 4:52 AM
Unknown Object (File)
Apr 2 2023, 1:10 AM
Unknown Object (File)
Apr 1 2023, 12:24 AM
View All 88 Files
Subscribers
None

Details

Reviewers
alangenfeld
• dgibson
• johann
Commits
R1:95bcd79c6fb6: Stub ECS TagResource for tasks only
Summary

https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_TagResource.html

The EcsRunLauncher will tag each task with the run_id so it can
identify them. Until there's a need to tag other types of resources
(clusters, task definitions, etc.), this stubbed endpoint will only
work for tasks.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jordansanders created this revision.Jun 16 2021, 4:04 PM
• jordansanders added a parent revision: D8400: Stub ECS ListTasks.Jun 16 2021, 4:09 PM
• jordansanders added a child revision: D8402: Stub ECS ListTagsForResource for tasks only.
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 4:29 PM
Harbormaster failed remote builds in B32167: Diff 39627!
• jordansanders updated this revision to Diff 39665.Jun 16 2021, 5:42 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 6:10 PM
Harbormaster failed remote builds in B32199: Diff 39665!
• jordansanders updated this revision to Diff 39685.Jun 16 2021, 7:22 PM

rebase

• jordansanders updated this revision to Diff 39703.Jun 16 2021, 8:00 PM

rebase

Harbormaster failed remote builds in B32217: Diff 39685!Jun 16 2021, 8:11 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 16 2021, 8:30 PM
Harbormaster failed remote builds in B32235: Diff 39703!
• jordansanders updated this revision to Diff 39752.Jun 17 2021, 2:33 PM

rebase

Harbormaster completed remote builds in B32275: Diff 39752.Jun 17 2021, 3:00 PM
• jordansanders requested review of this revision.Jun 17 2021, 3:00 PM
• dgibson accepted this revision.Jun 17 2021, 10:13 PM
This revision is now accepted and ready to land.Jun 17 2021, 10:13 PM
Closed by commit R1:95bcd79c6fb6: Stub ECS TagResource for tasks only (authored by • jordansanders). · Explain WhyJun 18 2021, 7:25 PM
This revision was automatically updated to reflect the committed changes.
• jordansanders added a commit: R1:95bcd79c6fb6: Stub ECS TagResource for tasks only.

Revision Contents
Changeset List

PathSize
python_modules/
libraries/
dagster-aws/
dagster_aws_tests/
ecs_tests/
29 lines
14 lines

Diff 39939

View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/stubbed_ecs.py

Loading...
View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/test_stubbed_ecs.py

Loading...