Paths

Table of Contentst

Differential D8384

[dagit] Crag: Job header
ClosedPublic
Actions

Authored by • dish on Jun 15 2021, 5:36 PM.

Details

Reviewers

• bengotow

Commits

R1:2c6d3dd34969: [dagit] Crag: Job header

Summary

For flagged users, show "Job" in the header for the job permalink, instead of "Pipeline".

Also created a useFeatureEnabled hook so that we don't always have to pull flag state from localstorage.

Test Plan

View a job page in Dagit, verify that the header link is updated.

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• dish created this revision.Jun 15 2021, 5:36 PM

Harbormaster completed remote builds in B32127: Diff 39573.Jun 15 2021, 5:45 PM

• dish requested review of this revision.Jun 15 2021, 5:45 PM

• bengotow accepted this revision.Jun 15 2021, 8:32 PM

• bengotow added inline comments.

js_modules/dagit/packages/core/src/nav/PipelineNav.tsx
112–113	We may want to replace this with pipelineMode as well

This revision is now accepted and ready to land.Jun 15 2021, 8:32 PM

+bengotow

Harbormaster completed remote builds in B32142: Diff 39595.Jun 15 2021, 9:33 PM

Closed by commit R1:2c6d3dd34969: [dagit] Crag: Job header (authored by • dish). · Explain WhyJun 15 2021, 9:53 PM

This revision was automatically updated to reflect the committed changes.

• dish added a commit: R1:2c6d3dd34969: [dagit] Crag: Job header.

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

packages/

core/

src/

app/

Util.tsx

6 lines

nav/

PipelineNav.tsx

13 lines

Diff 39599

View Options

js_modules/dagit/packages/core/src/app/Util.tsx