Page MenuHomeElementl

[dagit] Crag: Job header
ClosedPublic

Authored by dish on Jun 15 2021, 5:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 6, 3:43 PM
Unknown Object (File)
Tue, Jan 31, 5:44 AM
Unknown Object (File)
Sat, Jan 14, 6:10 PM
Unknown Object (File)
Nov 17 2022, 11:57 PM
Unknown Object (File)
Nov 17 2022, 11:57 PM
Unknown Object (File)
Nov 17 2022, 11:57 PM
Unknown Object (File)
Nov 17 2022, 11:57 PM
Unknown Object (File)
Nov 14 2022, 1:47 PM
Subscribers
None

Details

Summary

For flagged users, show "Job" in the header for the job permalink, instead of "Pipeline".

Also created a useFeatureEnabled hook so that we don't always have to pull flag state from localstorage.

Test Plan

View a job page in Dagit, verify that the header link is updated.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bengotow added inline comments.
js_modules/dagit/packages/core/src/nav/PipelineNav.tsx
112–113

We may want to replace this with pipelineMode as well

This revision is now accepted and ready to land.Jun 15 2021, 8:32 PM
This revision was automatically updated to reflect the committed changes.