Page MenuHomeElementl
Differential D8381

[dagit] Crag: Some nav tweaks
ClosedPublic
Actions

Authored by • dish on Jun 15 2021, 4:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 1, 4:29 PM
Unknown Object (File)
Fri, Jan 27, 2:11 AM
Unknown Object (File)
Sun, Jan 22, 12:46 PM
Unknown Object (File)
Sun, Jan 15, 11:07 PM
Unknown Object (File)
Jan 9 2023, 11:37 AM
Unknown Object (File)
Jan 2 2023, 9:37 PM
Unknown Object (File)
Dec 23 2022, 12:21 PM
Unknown Object (File)
Dec 19 2022, 7:38 AM
View All 63 Files
Subscribers
None

Details

Reviewers
• bengotow
Commits
R1:15ebe896cc79: [dagit] Crag: Some nav tweaks
Summary

A handful of tweaks to the flat jobs list in left nav.

  • Fix duplicate keying for name collisions by using the repo address.
  • Fix height for scrollable div.
  • Truncate job names with ellipsis.
Test Plan

Run Dagit, verify fixes described above.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• dish created this revision.Jun 15 2021, 4:45 PM
Harbormaster completed remote builds in B32114: Diff 39558.Jun 15 2021, 4:54 PM
• dish requested review of this revision.Jun 15 2021, 4:54 PM
• bengotow accepted this revision.Jun 15 2021, 8:35 PM
• bengotow added inline comments.
js_modules/dagit/packages/core/src/nav/FlatContentList.tsx
91–93

I wish it was a bit more clear that passing these on an item causes an icon to be added downstream... any chance we could do some sort of icon: resolveIcon(schedule, sensor) here to lift that conversion from sensor to icon up to here? I think it'd be nice because then the logic on 83 for $hasIcon wouldn't need to match the implementation inside JobItem.

109

Big fan of the inlining of the content helper here!

This revision is now accepted and ready to land.Jun 15 2021, 8:35 PM
• dish added inline comments.Jun 15 2021, 9:56 PM
js_modules/dagit/packages/core/src/nav/FlatContentList.tsx
92

I might do this in a followup. I'm not sure what we might need to change after meeting tomorrow.

Closed by commit R1:15ebe896cc79: [dagit] Crag: Some nav tweaks (authored by • dish). · Explain WhyJun 15 2021, 9:57 PM
This revision was automatically updated to reflect the committed changes.
• dish added a commit: R1:15ebe896cc79: [dagit] Crag: Some nav tweaks.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
core/
src/
nav/
54 lines

Diff 39600

View Options

js_modules/dagit/packages/core/src/nav/FlatContentList.tsx

Loading...