Page MenuHomeElementl

Move exploration of definitions to Graphs tab of Repository
ClosedPublic

Authored by bengotow on Jun 15 2021, 4:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 7, 6:42 PM
Unknown Object (File)
Wed, Feb 1, 9:49 PM
Unknown Object (File)
Wed, Jan 25, 12:15 AM
Unknown Object (File)
Tue, Jan 17, 8:30 PM
Unknown Object (File)
Jan 4 2023, 8:08 AM
Unknown Object (File)
Jan 3 2023, 12:30 PM
Unknown Object (File)
Dec 20 2022, 1:18 PM
Unknown Object (File)
Dec 3 2022, 5:16 PM
Subscribers
None

Details

Summary

This work is all behind the tuples feature flag. We conditionally hide the definition tab of the pipeline navigation, and add a new “Graphs” tab at the workspace level. The graphs tab shows composite solids as well as pipelines, and clicking down into one takes you to the pipeline explorer mounted at /workspace/repo@location/graphs/...

Caveats:

  • If you click to explore a composite solid, it shows you the first invocation of the composite solid because we can't currently retrieve their graphs outside the context of a pipeline. (TODO: Fix that the pipeline name is still shown in the title)
  • There's some slight scrolling wonkiness to the explorer
  • Everything is still named "PipelineExplorer" because I didn't want to wreck the diff
Test Plan

Run snapshot tests, poke at changes behind feature flag

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Fix title so composite solids look like graphs when in explorer is shown from /graphs/
  • Fix a few stray references to Pipelines in the workspcae repo explorer
  • Block access to the definition at the old paths, redirect to the overview (making overview the default)
js_modules/dagit/packages/core/src/pipelines/PipelineExplorer.tsx
131

Probably not ideal to have to parse this out of localStorage too often. We should probably make useFeatureEnabled or something that can memoize the value.

js_modules/dagit/packages/core/src/workspace/GraphRoot.tsx
32–33

Looks like this is a single-child Group, so shouldn't need Group. Also could probably consolidate some of the styles with Box.

42

This is what we're using for assets, right? Might be good to use a different one.

js_modules/dagit/packages/core/src/workspace/RepositoryGraphsList.tsx
112

Why 50%?

bengotow added inline comments.
js_modules/dagit/packages/core/src/pipelines/PipelineExplorer.tsx
131

Maybe let's merge this diff and then we can do a pass through all the featureEnabled callsites and convert them.

js_modules/dagit/packages/core/src/workspace/GraphRoot.tsx
42

Yep sounds good!

js_modules/dagit/packages/core/src/workspace/RepositoryGraphsList.tsx
112

Ahh good catch, this is a holdover from the Table I copied to make this one, will fix!

  • Fix title so composite solids look like graphs when in explorer is shown from /graphs/
  • Fix a few stray references to Pipelines in the workspcae repo explorer
  • Block access to the definition at the old paths, redirect to the overview (making overview the default)
  • Address diff feedback
This revision is now accepted and ready to land.Jun 16 2021, 2:59 PM