Page MenuHomeElementl

don't require context arg when solid has required resources
ClosedPublic

Authored by sandyryza on Jun 11 2021, 11:31 PM.

Details

Summary

There are legitimate reasons to require a resource on a solid, but not access it inside the solid:

  • The incoming dagster mlflow resource invokes some mlflow APIs that start an mlflow run and modify global state to point to it, and then the body of the solid can log to that run by just invoking direct APIs on the mlflow package.
  • step launchers
Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 11 2021, 11:52 PM
Harbormaster failed remote builds in B32028: Diff 39459!

Yea this makes sense to me. The step launcher case already made me a bit uneasy.

This revision is now accepted and ready to land.Jun 14 2021, 9:19 PM
python_modules/dagster/dagster/core/definitions/decorators/solid.py
79

honestly why not just drop it entirely at this point? what does this error help with ?

python_modules/dagster/dagster/core/definitions/decorators/solid.py
79

I don't have a particular opinion either way.

python_modules/dagster/dagster/core/definitions/decorators/solid.py
79

going to merge and we can always drop that later.