Page MenuHomeElementl

Dockerfile for hacker news example
Needs RevisionPublic

Authored by sandyryza on Jun 11 2021, 9:43 PM.

Details

Summary

I am a total Docker noob, so am likely doing something wrong here. Any recommendations on how to test?

Test Plan

todo

Diff Detail

Repository
R1 dagster
Branch
hacker-dockerfile (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

johann requested changes to this revision.Jun 15 2021, 8:49 PM

Going to discuss offline

Some things to decide on

  • secrets (ideally not baked in to the image)
  • should this be editable installing
This revision now requires changes to proceed.Jun 15 2021, 8:49 PM

Recording the outcome of conversation with @johann here:

  • In addition to the Dockerfile, we're going to include a build script that copies files to a relevant directory and then invokes the Dockerfile to build the image.
  • As a side thing, we should include the git hash as the docker image tag and/or as an environment variable that we can put as a tag on pipeline definitions.
  • Johann is going to write a unit test that ensures the Dockerfile builds.
  • We're going to remove the secrets from the image and tell users to manage them through their cluster manager.