Page MenuHomeElementl

[dagster-graphql-client] Make `use_https` required
AcceptedPublic

Authored by sidkmenon on Thu, Jun 10, 3:48 PM.

Details

Summary

After discussion with @catherinewu and @dgibson, decided to make use_https a required field on the Dagster GraphQL Client.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Branch
client-https (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

examples/docs_snippets/docs_snippets/concepts/dagit/graphql/client_example.py
6

a bit of a nitpick, but if we're going the required route, I think I'd like to see this written as DagsterGraphQLClient("localhost", use_https=False, port_number=3000) in most places. Otherwise it's a little bit mysterious to a person looking at these examples what this random bool is doing in the constructor.

add @owen's suggestion and this looks good to me

This revision is now accepted and ready to land.Thu, Jun 10, 5:12 PM