Page MenuHomePhabricator

Add EC2 setup script
ClosedPublic

Authored by nate on Aug 15 2019, 11:37 PM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:9070173172b3: Add EC2 setup script
Summary

well, I went for it and built the cute CLI tool ¯\_(ツ)_/¯

Test Plan

tested manually; after running, SSH to the VM and launch dagster examples with dagit -h <hostname> -p 80 and we're up

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nate created this revision.Aug 15 2019, 11:37 PM
nate added a comment.Aug 15 2019, 11:48 PM

Looks like this:

nate edited the summary of this revision. (Show Details)Aug 15 2019, 11:50 PM
nate added a reviewer: Restricted Project.

should put this somewhere other than bin?

TEST PLAN
manual

can you be a little more descriptive of what you tested? where you able to get dagster_examples running on a box?

nate edited the test plan for this revision. (Show Details)Aug 18 2019, 9:23 PM
nate updated this revision to Diff 3799.Aug 18 2019, 10:25 PM
nate edited the summary of this revision. (Show Details)

up

Harbormaster completed remote builds in B3043: Diff 3800.
nate updated this revision to Diff 3801.Aug 19 2019, 2:10 AM

add shell command

alangenfeld accepted this revision.Aug 19 2019, 7:48 PM

youve got enough code here to warrant breaking things out to a few files, now or in a subsequent diff

makeitso

bin/dagit-aws
39–61

if this is truly static maybe just move it to its own file

This revision is now accepted and ready to land.Aug 19 2019, 7:48 PM
This revision was automatically updated to reflect the committed changes.