Paths

Table of Contentst

Differential D8317

[dagster-graphql-client] Fix `get_run_status` return type
ClosedPublic
Actions

Authored by • sidkmenon on Jun 9 2021, 8:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 11, 12:17 AM

	Unknown Object (File)
	Fri, Feb 24, 7:46 PM

	Unknown Object (File)
	Tue, Feb 21, 2:35 PM

	Unknown Object (File)
	Feb 12 2023, 3:47 AM

	Unknown Object (File)
	Feb 9 2023, 6:54 AM

	Unknown Object (File)
	Feb 4 2023, 3:33 PM

	Unknown Object (File)
	Jan 4 2023, 6:30 AM

	Unknown Object (File)
	Dec 8 2022, 6:55 PM

View All 50 Files

Subscribers

Details

Reviewers

alangenfeld
• owen
• rexledesma

Commits

R1:706bcf8c270b: [dagster-graphql-client] Fix `get_run_status` return type

Summary

Thanks to Dylan Bienstock for pointing this out - the string returned from get_run_status needs to be manually coerced into a PipelineRunStatus object!

Test Plan

bk

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• sidkmenon created this revision.Jun 9 2021, 8:12 PM

Harbormaster completed remote builds in B31914: Diff 39309.Jun 9 2021, 8:38 PM

• sidkmenon requested review of this revision.Jun 9 2021, 8:38 PM

• rexledesma accepted this revision.Jun 9 2021, 8:45 PM

• rexledesma added a subscriber: • rexledesma.

• rexledesma added inline comments.

python_modules/dagster-graphql/dagster_graphql/client/client.py
247	`Dict[str, Any]` flexible typing got us 😩 wonder if it might be nice to have a tool that will autogen the python types for these queries (if such a thing even exists?)

This revision is now accepted and ready to land.Jun 9 2021, 8:45 PM

flexible typing got us

Also we dont run mypy in dagster-graphql https://dagster.phacility.com/source/dagster/browse/master/.buildkite/dagster-buildkite/dagster_buildkite/module_build_spec.py$9, we have to go back for that blacklist

Closed by commit R1:706bcf8c270b: [dagster-graphql-client] Fix `get_run_status` return type (authored by Sidharth Menon <menon.sid.k@gmail.com>). · Explain WhyJun 9 2021, 9:43 PM

This revision was automatically updated to reflect the committed changes.

Sidharth Menon <menon.sid.k@gmail.com> added a commit: R1:706bcf8c270b: [dagster-graphql-client] Fix `get_run_status` return type.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster-graphql/

dagster_graphql/

client/

2 lines

dagster_graphql_tests/

client_tests/

test_get_run_status.py

2 lines

Diff 39323

python_modules/dagster-graphql/dagster_graphql/client/client.py

Loading...

python_modules/dagster-graphql/dagster_graphql_tests/client_tests/test_get_run_status.py

Loading...