Page MenuHomeElementl
Differential D8313

[dagster-graphql-client] Fixing Exception messages
ClosedPublic
Actions

Authored by • sidkmenon on Jun 9 2021, 5:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 14, 2:59 AM
Unknown Object (File)
Mon, May 8, 5:50 PM
Unknown Object (File)
Apr 24 2023, 2:52 AM
Unknown Object (File)
Mar 10 2023, 3:21 PM
Unknown Object (File)
Mar 3 2023, 4:57 PM
Unknown Object (File)
Feb 12 2023, 10:47 AM
Unknown Object (File)
Feb 11 2023, 2:01 AM
Unknown Object (File)
Feb 5 2023, 3:35 AM
View All 35 Files
Subscribers
None

Details

Reviewers
• owen
Commits
R1:5d1f607e1f60: [dagster-graphql-client] Fixing Exception messages
Summary

In light of user experiences with the GraphQL client's exception messages, this diff adds some clarity to possible error messages that may come up in the usage of the GraphQL client & also adds new information to the docstrings

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• sidkmenon created this revision.Jun 9 2021, 5:46 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 9 2021, 6:09 PM
Harbormaster failed remote builds in B31903: Diff 39293!
• sidkmenon updated this revision to Diff 39296.Jun 9 2021, 6:31 PM

rebase

Harbormaster completed remote builds in B31904: Diff 39296.Jun 9 2021, 6:58 PM
• sidkmenon requested review of this revision.Jun 9 2021, 6:58 PM
• sidkmenon updated this revision to Diff 39311.Jun 9 2021, 8:17 PM

Fix docstrings

Harbormaster completed remote builds in B31915: Diff 39311.Jun 9 2021, 8:42 PM
• owen accepted this revision.Jun 9 2021, 8:47 PM

nice

This revision is now accepted and ready to land.Jun 9 2021, 8:47 PM
• sidkmenon updated this revision to Diff 39317.Jun 9 2021, 9:19 PM

more docstring edits

This revision was landed with ongoing or failed builds.Jun 9 2021, 9:42 PM
Closed by commit R1:5d1f607e1f60: [dagster-graphql-client] Fixing Exception messages (authored by Sidharth Menon <menon.sid.k@gmail.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Sidharth Menon <menon.sid.k@gmail.com> added a commit: R1:5d1f607e1f60: [dagster-graphql-client] Fixing Exception messages.
Harbormaster completed remote builds in B31919: Diff 39317.Jun 9 2021, 10:05 PM

Revision Contents
Changeset List

PathSize
docs/
content/
api/
python_modules/
dagster-graphql/
dagster_graphql/
client/
23 lines

Diff 39311

View Options

docs/content/api/modules.json

Loading...
View Options

docs/content/api/searchindex.json

Loading...
View Options

docs/content/api/sections.json

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/client/client.py

Loading...