Page MenuHomeElementl

feat: set default image tags of Dagster provided images in Helm chart to current Chart version
ClosedPublic

Authored by rexledesma on Jun 9 2021, 5:24 AM.
Tags
None
Referenced Files
F2295950: D8301.diff
Fri, Jul 1, 9:47 PM
Unknown Object (File)
Tue, Jun 21, 3:33 PM
Unknown Object (File)
Sat, Jun 18, 5:21 AM
Unknown Object (File)
Fri, Jun 17, 8:04 PM
Unknown Object (File)
Tue, Jun 14, 12:17 AM
Unknown Object (File)
Mon, Jun 6, 12:20 AM
Unknown Object (File)
Fri, Jun 3, 7:17 PM
Unknown Object (File)
May 28 2022, 1:26 PM
Subscribers
None

Details

Summary

Resolves https://github.com/dagster-io/dagster/issues/4229.

For images in the Helm chart that default to a Dagster provided image, the tag is now null.
We now use .Chart.Version to populate the value of this tag if it is null.

Test Plan

pytest
integration

Diff Detail

Repository
R1 dagster
Branch
rl/helm-couple-image-tag (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

rexledesma retitled this revision from Set default image tags of Dagster provided images in Helm chart to current Chart version to feat: set default image tags of Dagster provided images in Helm chart to current Chart version.Jun 10 2021, 1:22 PM

Awesome! I think this will deserve at least a callout in the #dagster-kubernetes channel, it's a decent quality-of-life improvement.

For release we will need to make sure the images are always published before the chart

This revision is now accepted and ready to land.Jun 10 2021, 1:31 PM