Paths

Table of Contentst

Differential D8301

feat: set default image tags of Dagster provided images in Helm chart to current Chart version
ClosedPublic
Actions

Authored by • rexledesma on Jun 9 2021, 5:24 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 30, 9:16 PM

	Unknown Object (File)
	Wed, May 24, 12:30 AM

	Unknown Object (File)
	Apr 27 2023, 8:54 PM

	Unknown Object (File)
	Apr 19 2023, 8:32 AM

	Unknown Object (File)
	Apr 3 2023, 5:10 AM

	Unknown Object (File)
	Mar 31 2023, 8:11 PM

	Unknown Object (File)
	Mar 23 2023, 1:28 PM

	Unknown Object (File)
	Mar 19 2023, 3:38 AM

View All 79 Files

Subscribers

None

Details

Reviewers

• jordansanders
• sidkmenon
• johann

Commits

R1:6954c79d6f0f: feat: set default image tags of Dagster provided images in Helm chart to…

Summary

Resolves https://github.com/dagster-io/dagster/issues/4229.

For images in the Helm chart that default to a Dagster provided image, the tag is now null.
We now use .Chart.Version to populate the value of this tag if it is null.

Test Plan

pytest
integration

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• rexledesma created this revision.Jun 9 2021, 5:24 AM

Harbormaster completed remote builds in B31859: Diff 39239.Jun 9 2021, 5:50 AM

• rexledesma requested review of this revision.Jun 9 2021, 5:50 AM

• rexledesma retitled this revision from Set default image tags of Dagster provided images in Helm chart to current Chart version to feat: set default image tags of Dagster provided images in Helm chart to current Chart version.Jun 10 2021, 1:22 PM

Awesome! I think this will deserve at least a callout in the #dagster-kubernetes channel, it's a decent quality-of-life improvement.

For release we will need to make sure the images are always published before the chart

This revision is now accepted and ready to land.Jun 10 2021, 1:31 PM

Closed by commit R1:6954c79d6f0f: feat: set default image tags of Dagster provided images in Helm chart to… (authored by • rexledesma). · Explain WhyJun 10 2021, 1:45 PM

This revision was automatically updated to reflect the committed changes.

• rexledesma added a commit: R1:6954c79d6f0f: feat: set default image tags of Dagster provided images in Helm chart to….

Revision Contents
Changeset List

Path

Size

helm/

dagster/

charts/

dagster-user-deployments/

templates/

deployment-user.yaml

4 lines

helpers/

9 lines

values.schema.json

5 lines

schema/

schema/

charts/

dagster/

subschema/

4 lines

4 lines

6 lines

utils/

12 lines

schema_tests/

helm_template.py

54 lines

test_celery_queues.py

60 lines

38 lines

test_dagster_daemon.py

34 lines

test_user_deployments.py

37 lines

templates/

deployment-celery-queues.yaml

4 lines

deployment-daemon.yaml

4 lines

deployment-flower.yaml

2 lines

helpers/

_deployment-dagit.tpl

6 lines

13 lines

instance/

_run-launcher.tpl

2 lines

2 lines

job-instance-migrate.yaml

2 lines

tests/

test-connection.yaml

2 lines

values.schema.json

30 lines

Diff 39346

helm/dagster/charts/dagster-user-deployments/templates/deployment-user.yaml

Loading...

helm/dagster/charts/dagster-user-deployments/templates/helpers/_helpers.tpl

Loading...

helm/dagster/charts/dagster-user-deployments/values.schema.json

Loading...

helm/dagster/charts/dagster-user-deployments/values.yaml

Loading...

helm/dagster/schema/schema/charts/dagster/subschema/busybox.py

Loading...

helm/dagster/schema/schema/charts/dagster/subschema/postgresql.py

Loading...

helm/dagster/schema/schema/charts/dagster/subschema/rabbitmq.py

Loading...

helm/dagster/schema/schema/charts/utils/kubernetes.py

Loading...

helm/dagster/schema/schema_tests/helm_template.py

Loading...

helm/dagster/schema/schema_tests/test_celery_queues.py

Loading...

helm/dagster/schema/schema_tests/test_dagit.py

Loading...

helm/dagster/schema/schema_tests/test_dagster_daemon.py

Loading...

helm/dagster/schema/schema_tests/test_user_deployments.py

Loading...

helm/dagster/templates/deployment-celery-queues.yaml

Loading...

helm/dagster/templates/deployment-daemon.yaml

Loading...

helm/dagster/templates/deployment-flower.yaml

Loading...

helm/dagster/templates/helpers/_deployment-dagit.tpl

Loading...

helm/dagster/templates/helpers/_helpers.tpl

Loading...

helm/dagster/templates/helpers/instance/_run-launcher.tpl

Loading...

helm/dagster/templates/helpers/instance/_scheduler.tpl

Loading...

helm/dagster/templates/job-instance-migrate.yaml

Loading...

helm/dagster/templates/tests/test-connection.yaml

Loading...

helm/dagster/values.schema.json

Loading...

helm/dagster/values.yaml

Loading...