Paths

Table of Contentst

Differential D8299

intro RunRecord and get_run_rows -> get_run_records
ClosedPublic
Actions

Authored by • yuhan on Jun 8 2021, 11:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Mar 17, 12:37 PM

	Unknown Object (File)
	Wed, Mar 15, 9:59 AM

	Unknown Object (File)
	Wed, Mar 15, 9:41 AM

	Unknown Object (File)
	Mon, Mar 13, 1:52 PM

	Unknown Object (File)
	Tue, Mar 7, 12:54 AM

	Unknown Object (File)
	Tue, Feb 28, 3:04 PM

	Unknown Object (File)
	Mon, Feb 27, 2:06 PM

	Unknown Object (File)
	Feb 21 2023, 7:20 PM

View All 52 Files

Subscribers

None

Details

Reviewers

• dgibson
alangenfeld

Commits

R1:5aa8eae57833: intro RunRecord and get_run_rows -> get_run_records

Summary

introduce a wrapper RunRecord to wrap run storage row

class RunRecord(NamedTuple):
    record_id: int
    pipeline_run: PipelineRun
    create_timestamp: datetime
    update_timestamp: datetime

rename get_run_rows to get_run_records and it returns List[RunRecord] instead of List of row dict

Test Plan

bk

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• yuhan created this revision.Jun 8 2021, 11:36 PM

• yuhan added a child revision: Restricted Differential Revision.Jun 8 2021, 11:46 PM

• yuhan added a parent revision: D7476: monitor sensor prototype.

Harbormaster completed remote builds in B31848: Diff 39223.Jun 9 2021, 12:00 AM

• yuhan requested review of this revision.Jun 9 2021, 12:00 AM

• yuhan mentioned this in D8213: pipeline sensor - fetch events without run id + sqlite trick.Jun 9 2021, 12:42 AM

I think this is a bit cleaner, thanks for the quick turn around

python_modules/dagster/dagster/core/instance/__init__.py
996–1010	nit: doc block here too?
python_modules/dagster/dagster/core/storage/pipeline_run.py
394–399	doc block explaining
python_modules/dagster/dagster/core/storage/runs/base.py
143–144	update
python_modules/dagster/dagster/core/storage/runs/in_memory.py
141–142	this should be easier now (or at least make a bit more sense)

This revision is now accepted and ready to land.Jun 9 2021, 2:20 PM

udpate docstring

Harbormaster completed remote builds in B31905: Diff 39297.Jun 9 2021, 7:46 PM

Closed by commit R1:5aa8eae57833: intro RunRecord and get_run_rows -> get_run_records (authored by • yuhan). · Explain WhyJun 9 2021, 11:34 PM

This revision was automatically updated to reflect the committed changes.

• yuhan added a commit: R1:5aa8eae57833: intro RunRecord and get_run_rows -> get_run_records.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

dagster/

core/

definitions/

pipeline_sensor.py

10 lines

instance/

25 lines

storage/

pipeline_run.py

12 lines

runs/

13 lines

4 lines

sql_run_storage.py

26 lines

dagster_tests/

core_tests/

storage_tests/

utils/

14 lines

Diff 39335

python_modules/dagster/dagster/core/definitions/pipeline_sensor.py

Loading...

python_modules/dagster/dagster/core/instance/init.py

Loading...

python_modules/dagster/dagster/core/storage/pipeline_run.py

Loading...

python_modules/dagster/dagster/core/storage/runs/base.py

Loading...

python_modules/dagster/dagster/core/storage/runs/in_memory.py

Loading...

python_modules/dagster/dagster/core/storage/runs/sql_run_storage.py

Loading...

python_modules/dagster/dagster_tests/core_tests/storage_tests/utils/run_storage.py

Loading...