Page MenuHomeElementl

type annotations for _CacheingDefinitionIndex
ClosedPublic

Authored by sandyryza on Jun 7 2021, 8:35 PM.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alangenfeld added inline comments.
python_modules/dagster/dagster/core/definitions/repository.py
26–36

did you mess around with TypeVar / generics here? I haven't been able to actually get it working for altering the return type when its specified by argument, definition_class in this case, but you could try and see if you can crack it

This revision is now accepted and ready to land.Jun 8 2021, 1:18 AM

up

python_modules/dagster/dagster/core/definitions/repository.py
26–36

gave it a shot, and I think it's an improvement. is this what you had in mind?