Page MenuHomeElementl

[dagit] Fix stdout/stderr log view
ClosedPublic

Authored by dish on Mon, Jun 7, 6:50 PM.

Details

Summary

Resolves #4254.

When viewing the stdout/stderr option in Run logs, the step selector doesn't set the selected value correctly. Links from the logs themselves also do not navigate to the correct step. Fix this by tracking logKey in the URL query. This allows us to link directly to the view of that log key in the log item itself, and repairs the select element.

Test Plan

View a run. Click to stdout view, change selected step. Verify that the select updates properly, the URL updates properly, and the stdout/stderr is correct.

Click a "View stdout/stderr" link on a log item. Verify that it goes to the correct log key in the stdout view.

Reload the page with query param set, verify that it loads the stdout view correctly.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Mon, Jun 7, 7:01 PM
This revision is now accepted and ready to land.Tue, Jun 8, 3:55 PM
This revision was automatically updated to reflect the committed changes.