Fixes for dagster-mysql local runs
ClosedPublic
Actions

Authored by • dgibson on Jun 7 2021, 4:07 PM.

Tags

None

Referenced Files

	F2990315: D8268.diff
	Fri, Jun 9, 2:06 PM

	Unknown Object (File)
	Sat, May 27, 12:19 AM

	Unknown Object (File)
	Sun, May 14, 10:32 AM

	Unknown Object (File)
	May 6 2023, 10:32 PM

	Unknown Object (File)
	May 2 2023, 1:19 AM

	Unknown Object (File)
	Apr 23 2023, 7:04 AM

	Unknown Object (File)
	Apr 8 2023, 1:45 AM

	Unknown Object (File)
	Apr 7 2023, 6:46 PM

View All 75 Files

Subscribers

None

Details

Reviewers

• sidkmenon
alangenfeld
• prha

Commits

R1:af575b062831: Fixes for dagster-mysql local runs

Summary

don't re-create the docker-compose file on each test, that is slow
add a new connection error to the set of errors we retry on

Test Plan

BK, run dagster-mysql locally

Diff Detail

Repository

R1 dagster

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

• dgibson created this revision.Jun 7 2021, 4:07 PM

Harbormaster completed remote builds in B31758: Diff 39108.Jun 7 2021, 4:32 PM

• dgibson requested review of this revision.Jun 7 2021, 4:32 PM

lgtm! Haven't run into the Interface error personally but I figure if it's working locally for you it's fine!

This revision is now accepted and ready to land.Jun 7 2021, 4:33 PM

Closed by commit R1:af575b062831: Fixes for dagster-mysql local runs (authored by • dgibson). · Explain WhyJun 7 2021, 4:39 PM

This revision was automatically updated to reflect the committed changes.

• dgibson added a commit: R1:af575b062831: Fixes for dagster-mysql local runs.

Revision Contents
Changeset List

Path

Size

python_modules/

libraries/

dagster-mysql/

dagster_mysql/

utils.py

1 line

dagster_mysql_tests/

conftest.py

4 lines

Diff 39108

View Options

python_modules/libraries/dagster-mysql/dagster_mysql/utils.py