Differential D8264
Do Postgres/MySQL table creation in a transaction Authored by dgibson on Mon, Jun 7, 2:55 PM. Tags None Subscribers None
Details User asked why we don't do this and I didn't have a great answer. Let's do the table creation and alembic writes all in one big transaction. (There is still some jankiness from the fact that we share alembic configs between the three different storage classes - ideally there would be some way to do the full table creation all in one transaction, but this is still an improvement I think) BK
Diff Detail
Event TimelineComment Actions something about doing this in a transaction now made sqlalchemy complain about not setting an index length on some indices in mysql, picked a reasonable-looking default. Do I need to add these as a migration? (The index isn't new, just hte length restriction) |
