Page MenuHomeElementl

[dagit] Restore schema.graphql to repo
ClosedPublic

Authored by dish on Jun 7 2021, 2:29 PM.

Details

Summary

I realized when spinning up vscode today that our eslintrc requires schema.graphql to be present in order to lint GraphQL queries. I don't want anyone to have to run generate-graphql manually after checking the repo out fresh, just to pass lint, so I'm going to put the file back into the repo.

Since Buildkite will still regenerate the GraphQL types, any lint mismatches will still be caught by the build. Engineers might just miss them locally if they fail to regenerate types, which was the case anyway.

Test Plan

Buildkite. Run vscode, open a TS file in dagit/core. Verify that eslint starts up correctly.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Jun 7 2021, 2:40 PM
This revision is now accepted and ready to land.Jun 7 2021, 2:54 PM
This revision was automatically updated to reflect the committed changes.