Details

Reviewers

cdecarolis
alangenfeld
max

Commits

R1:f53b75009228: [RFC] remove PIPELINE_INIT_FAILURE event

Summary

squash PIPELINE_INIT_FAILURE into PIPELINE_FAILURE

Test Plan

backcompat test
dagit before:
after:

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuhan created this revision.Jun 3 2021, 7:05 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 3 2021, 7:26 PM

Harbormaster failed remote builds in B31622: Diff 38932!

-PipelineInitFailureData

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 3 2021, 8:09 PM

Harbormaster failed remote builds in B31634: Diff 38948!

pipeline_context -> pipeline_context_or_name so mypy is happy and code isn't too ugly

Harbormaster completed remote builds in B31641: Diff 38958.Jun 3 2021, 9:15 PM

yuhan requested review of this revision.Jun 3 2021, 9:15 PM

think this looks about right to me

python_modules/dagster/dagster/core/events/__init__.py
1421–1434	dont forget to add a tombstone

+tombstone

Harbormaster completed remote builds in B31664: Diff 38986.Jun 3 2021, 11:23 PM

ill leave this up a little longer to allow others to chime in

seems likely well land this though, can you add a compat test that has a pipeline init failure in it ? https://dagster.phacility.com/source/dagster/browse/master/python_modules/dagster/dagster_tests/general_tests/compat_tests

maybe also a before and after dagit screenshot if you are feeling generous

max added inline comments.Jun 4 2021, 8:02 PM

python_modules/dagster/dagster/core/events/__init__.py
1422	FOR WHOM THE BELL TOLLS

i agree with alex and think this is just great

+test
bring PipelineInitFailureData so old runs wont crash in dagit

yuhan edited the test plan for this revision. (Show Details)Jun 5 2021, 5:30 AM

Harbormaster completed remote builds in B31747: Diff 39095.Jun 5 2021, 5:52 AM

welldone

python_modules/dagster/dagster/core/events/__init__.py
770–773	can we just use the `context_msg` like above for the init failure case instead of encoding these assumptions about use - i think its better to dupe at call sites then to have this message show up unexpectedly in some future case

This revision is now accepted and ready to land.Jun 8 2021, 12:51 AM

Harbormaster completed remote builds in B31854: Diff 39233.Jun 9 2021, 12:24 AM

Closed by commit R1:f53b75009228: [RFC] remove PIPELINE_INIT_FAILURE event (authored by yuhan). · Explain WhyJun 9 2021, 6:20 PM

This revision was automatically updated to reflect the committed changes.

yuhan added a commit: R1:f53b75009228: [RFC] remove PIPELINE_INIT_FAILURE event.

[RFC] remove PIPELINE_INIT_FAILURE eventClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39295

integration_tests/test_suites/k8s-integration-test-suite/test_integration.py

js_modules/dagit/packages/core/src/graphql/possibleTypes.generated.json

js_modules/dagit/packages/core/src/runs/LogsProvider.tsx

js_modules/dagit/packages/core/src/runs/LogsRow.tsx

js_modules/dagit/packages/core/src/runs/LogsRowStructuredContent.tsx

js_modules/dagit/packages/core/src/runs/RunMetadataProvider.tsx

js_modules/dagit/packages/core/src/runs/types/LogsRowStructuredFragment.ts

js_modules/dagit/packages/core/src/runs/types/LogsRowUnstructuredFragment.ts

js_modules/dagit/packages/core/src/runs/types/LogsScrollingTableMessageFragment.ts

js_modules/dagit/packages/core/src/runs/types/PipelineRunLogsSubscription.ts

js_modules/dagit/packages/core/src/runs/types/RunLogsQuery.ts

js_modules/dagit/packages/core/src/runs/types/RunMetadataProviderMessageFragment.ts

js_modules/dagit/packages/core/src/runs/types/RunPipelineRunEventFragment.ts

js_modules/dagit/packages/core/src/types/globalTypes.ts

python_modules/dagster-graphql/dagster_graphql/client/query.py

python_modules/dagster-graphql/dagster_graphql/implementation/events.py

python_modules/dagster-graphql/dagster_graphql/schema/logs/__init__.py

python_modules/dagster-graphql/dagster_graphql/schema/logs/events.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_assets.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_composites.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_compute_logs.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_environment_schema.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_materializations.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_partition_sets.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_presets.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_reexecution.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_sensors.py

python_modules/dagster/dagster/core/events/__init__.py

python_modules/dagster/dagster/core/execution/context_creation_pipeline.py

python_modules/dagster/dagster/core/execution/host_mode.py

python_modules/dagster/dagster/core/storage/runs/in_memory.py

python_modules/dagster/dagster/core/storage/runs/sql_run_storage.py

python_modules/dagster/dagster_tests/core_tests/definitions_tests/test_executor_definition.py

python_modules/dagster/dagster_tests/core_tests/engine_tests/test_multiprocessing.py

python_modules/dagster/dagster_tests/general_tests/compat_tests/test_dead_events.py

[RFC] remove PIPELINE_INIT_FAILURE event
ClosedPublic
Actions

Revision Contents
Changeset List

python_modules/dagster-graphql/dagster_graphql/schema/logs/init.py

python_modules/dagster/dagster/core/events/init.py