squash PIPELINE_INIT_FAILURE into PIPELINE_FAILURE
Details
- backcompat test
- dagit before: after:
Diff Detail
- Repository
- R1 dagster
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
pipeline_context -> pipeline_context_or_name so mypy is happy and code isn't too ugly
think this looks about right to me
python_modules/dagster/dagster/core/events/__init__.py | ||
---|---|---|
1421–1434 | dont forget to add a tombstone |
ill leave this up a little longer to allow others to chime in
seems likely well land this though, can you add a compat test that has a pipeline init failure in it ? https://dagster.phacility.com/source/dagster/browse/master/python_modules/dagster/dagster_tests/general_tests/compat_tests
maybe also a before and after dagit screenshot if you are feeling generous
python_modules/dagster/dagster/core/events/__init__.py | ||
---|---|---|
1422 | FOR WHOM THE BELL TOLLS |
python_modules/dagster/dagster/core/events/__init__.py | ||
---|---|---|
770–773 | can we just use the context_msg like above for the init failure case instead of encoding these assumptions about use - i think its better to dupe at call sites then to have this message show up unexpectedly in some future case |