Page MenuHomeElementl

Don't call DagsterInstance.get() in create_daemon_of_type
AbandonedPublic

Authored by dgibson on Jun 3 2021, 6:04 PM.

Details

Summary

DagsterInstance is a contextmanager object, and we already have an instance.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
nodaginstget (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Should we consider raising an error when .get is called outside of a context manager? Something like https://stackoverflow.com/a/54514410/14656695

I like that idea

(Rex ran with this fix so abandoning mine)