Page MenuHomeElementl

fix: create daemons without using reference to instance
ClosedPublic

Authored by rexledesma on Jun 3 2021, 5:58 PM.

Details

Summary

We should supply any necessary information from the instance during the daemon run iteration, rather than saving information from the instance.

Test Plan

N/A

Diff Detail

Repository
R1 dagster
Branch
rl/use-same-instance-for-daemons (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

rexledesma retitled this revision from Pass in same reference to instance when creating daemons to Create daemons without using reference to instance.Jun 3 2021, 7:34 PM
rexledesma edited the summary of this revision. (Show Details)
dgibson requested changes to this revision.Jun 3 2021, 7:36 PM

thanks for doing this! One small thing and we're good I think (let's merge create() with the constructor)

python_modules/dagster/dagster/daemon/daemon.py
54–59 ↗(On Diff #38939)

I don't see the value of this method - can we call the constructor directly?

This revision now requires changes to proceed.Jun 3 2021, 7:36 PM
rexledesma added a child revision: Restricted Differential Revision.Jun 9 2021, 10:57 PM
rexledesma retitled this revision from Create daemons without using reference to instance to fix: create daemons without using reference to instance.Jun 10 2021, 1:23 PM
This revision is now accepted and ready to land.Jun 11 2021, 2:36 PM

probably will require a quick internal change too right?